[00:08] ink0gnito (~ink0gnito@5.79.74.141) left irc: Ping timeout: 240 seconds [00:10] ink0gnito (~ink0gnito@5.79.74.141) joined #scummvm. [01:10] t0by (~t0by@unaffiliated/t0by) left irc: Remote host closed the connection [01:18] lb_ii_ (5f19f288@gateway/web/freenode/ip.95.25.242.136) left irc: Quit: Page closed [01:35] lb_ii: a bit off-topic, but I see you have a Ren'Py decompiler up there. A general-purpose decompiler we use in our projects may interest you https://github.com/zrax/pycdc/ [01:44] Zorix (~Brandon@2601:6c0:8002:3c8:11c4:d880:7cb7:aaa7) left irc: Ping timeout: 265 seconds [01:55] Zorix (~Brandon@2601:6c0:8002:3c8:4c93:1db5:9b36:5df4) joined #scummvm. [02:01] dreammaster (~dreammast@c-67-180-185-91.hsd1.ca.comcast.net) joined #scummvm. [02:01] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [02:02] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 260 seconds [02:03] Dominus (~dominus@unaffiliated/dominus) joined #scummvm. [02:26] mataniko (~mataniko@cpe-184-153-7-51.nyc.res.rr.com) left irc: Read error: Connection reset by peer [04:31] ignalina (~pettersjo@h-238-27.A639.priv.bahnhof.se) left irc: Quit: ignalina [05:35] SupSuper (~SupSuper@openxcom/dev/supsuper) left irc: Quit: Rip [05:45] dreammaster (~dreammast@c-67-180-185-91.hsd1.ca.comcast.net) left irc: [06:05] borosky (~borosky@095160159167.dynamic-ra-12.vectranet.pl) left irc: Read error: Connection reset by peer [06:06] borosky (~borosky@095160159167.dynamic-ra-12.vectranet.pl) joined #scummvm. [06:07] rootfather (~rootfathe@unaffiliated/rootfather) joined #scummvm. [06:07] #scummvm: mode change '+o rootfather' by ChanServ!ChanServ@services. [06:07] morning folks [06:19] borosky (~borosky@095160159167.dynamic-ra-12.vectranet.pl) left irc: Read error: Connection reset by peer [06:20] borosky (~borosky@095160159167.dynamic-ra-12.vectranet.pl) joined #scummvm. [06:39] scummvm-bugs (~scummvm-b@84-112-51-58.cable.dynamic.surfer.at) joined #scummvm. [06:46] scummvm-bugs (~scummvm-b@84-112-51-58.cable.dynamic.surfer.at) left irc: Remote host closed the connection [06:46] scummvm-bugs (~scummvm-b@84-112-51-58.cable.dynamic.surfer.at) joined #scummvm. [06:47] scummvm-bugs (~scummvm-b@84-112-51-58.cable.dynamic.surfer.at) left irc: Remote host closed the connection [06:48] morning [06:49] scummvm-bugs (~scummvm-b@84-112-51-58.cable.dynamic.surfer.at) joined #scummvm. [07:13] KAT (~K4T@93.179.200.166) joined #scummvm. [07:24] <_sev> Deledrius: morning [07:33] morning Deledrius _sev [07:36] borosky (~borosky@095160159167.dynamic-ra-12.vectranet.pl) left irc: Read error: Connection reset by peer [07:36] tsoliman (~tsoliman@scummvm/undead/tsoliman) left irc: Ping timeout: 256 seconds [07:37] stroggoff (~Praetoria@2a02:587:6008:7d00:75fd:edd1:3ca0:d78) joined #scummvm. [07:37] tsoliman (~tsoliman@scummvm/undead/tsoliman) joined #scummvm. [07:37] #scummvm: mode change '+o tsoliman' by ChanServ!ChanServ@services. [07:37] Hi guys [07:39] borosky (~borosky@095160159167.dynamic-ra-12.vectranet.pl) joined #scummvm. [07:40] hi stroggoff [07:41] :) [07:41] I´m still working on my PR for Blade Runner subtitles. It´s just that I couldn find much spare time for a few weeks [07:45] Dark-Star (~quassel@h2387211.stratoserver.net) left irc: Read error: Connection reset by peer [07:45] heroux (sandroco@gateway/shell/insomnia247/x-ftxqgyxvxlfudtht) left irc: Ping timeout: 256 seconds [07:45] Nick change: heroux_ -> heroux [07:46] Dark-Star (~quassel@2a01:238:427f:2f00:3060:fc6b:969e:dcf0) joined #scummvm. [07:47] heroux_ (sandroco@gateway/shell/insomnia247/x-pnafyupohykudtvt) joined #scummvm. [07:56] Lightkey (~Darklock@p200300F693C2B13322CF30FFFE083718.dip0.t-ipconnect.de) left irc: Ping timeout: 260 seconds [08:30] rootfather (~rootfathe@unaffiliated/rootfather) left irc: Remote host closed the connection [09:02] _sev (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [09:03] _sev (~sev@92.red-88-19-177.staticip.rima-tde.net) joined #scummvm. [09:03] _sev (~sev@92.red-88-19-177.staticip.rima-tde.net) left irc: Changing host [09:03] _sev (~sev@scummvm/undead/sev) joined #scummvm. [09:03] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [09:05] GitHub48 (GitHub48@gateway/service/github.com/x-spzcnyychdptmsyu) joined #scummvm. [09:05] [scummvm] sev- pushed 1 new commit to master: https://git.io/fNKnh [09:05] scummvm/master d796670 Eugene Sandulenko: NEWS: Formatting fixes [09:05] GitHub48 (GitHub48@gateway/service/github.com/x-spzcnyychdptmsyu) left #scummvm. [09:24] stroggoff (~Praetoria@2a02:587:6008:7d00:75fd:edd1:3ca0:d78) left irc: Quit: Leaving [09:39] _sev (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [09:41] _sev (~sev@92.red-88-19-177.staticip.rima-tde.net) joined #scummvm. [09:41] _sev (~sev@92.red-88-19-177.staticip.rima-tde.net) left irc: Changing host [09:41] _sev (~sev@scummvm/undead/sev) joined #scummvm. [09:41] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [09:44] Lightkey (~Darklock@p200300F693C2B18722CF30FFFE083718.dip0.t-ipconnect.de) joined #scummvm. [09:53] _sev (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [09:59] _sev (~sev@scummvm/undead/sev) joined #scummvm. [09:59] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [10:01] criezy|Work (a5e15055@gateway/web/freenode/ip.165.225.80.85) joined #scummvm. [10:01] #scummvm: mode change '+o criezy|Work' by ChanServ!ChanServ@services. [10:02] _sev (~sev@scummvm/undead/sev) left irc: Client Quit [10:12] _sev (~sev@92.red-88-19-177.staticip.rima-tde.net) joined #scummvm. [10:12] _sev (~sev@92.red-88-19-177.staticip.rima-tde.net) left irc: Changing host [10:12] _sev (~sev@scummvm/undead/sev) joined #scummvm. [10:12] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [10:13] Drenn (~Drenn@toroon0713w-lp140-02-69-157-8-46.dsl.bell.ca) left irc: Ping timeout: 260 seconds [10:33] KAT (~K4T@93.179.200.166) left irc: Ping timeout: 265 seconds [10:50] stroggoff (~Praetoria@2a02:587:6008:7d00:14b:35e:8c3d:689d) joined #scummvm. [10:57] _sev: I read your new comment on the PR for Blade Runner subtitles. I think I was looking mainly at the wrong wordwrap(?). I thought I was supposed to use the wordWrap in common/str.cpp [10:58] But the wordWrapText in the graphics/font.cpp is indeed closer to what I´m doing [10:58] <_sev> Graphics::Font::wordWrapText() [10:58] Yes [10:59] But still this works with scummVM´s Font objects, whereas I´m working with BladeRunner engine´s Font objects. [11:00] Should I attempt to change BladeRunner´s Font so that it would inherit from Graphics::Font ? [11:10] ignalina (~pettersjo@h-238-27.A639.priv.bahnhof.se) joined #scummvm. [11:12] LubomirR (d94b5cf3@gateway/web/freenode/ip.217.75.92.243) joined #scummvm. [11:31] Yuv422 (~Yuv422@60-240-103-165.tpgi.com.au) joined #scummvm. [11:35] _sev (~sev@scummvm/undead/sev) left irc: Ping timeout: 244 seconds [11:53] rootfather (~rootfathe@unaffiliated/rootfather) joined #scummvm. [11:53] #scummvm: mode change '+o rootfather' by ChanServ!ChanServ@services. [12:09] ccawley2011 (5690a207@gateway/web/freenode/ip.86.144.162.7) joined #scummvm. [12:23] ignalina (~pettersjo@h-238-27.A639.priv.bahnhof.se) left irc: Quit: ignalina [12:33] whiterandrek (~CVoltage@37.73.225.247) joined #scummvm. [12:33] #scummvm: mode change '+o whiterandrek' by ChanServ!ChanServ@services. [13:23] Yuv422 (~Yuv422@60-240-103-165.tpgi.com.au) left irc: Quit: Yuv422 [13:47] mataniko (~mataniko@cpe-184-153-7-51.nyc.res.rr.com) joined #scummvm. [13:47] #scummvm: mode change '+o mataniko' by ChanServ!ChanServ@services. [13:55] hi mataniko [13:55] good morning [14:27] whiterandrek (~CVoltage@37.73.225.247) left irc: Read error: Connection reset by peer [14:49] ignalina (~pettersjo@h-238-27.A639.priv.bahnhof.se) joined #scummvm. [14:52] rootfather (~rootfathe@unaffiliated/rootfather) left irc: Quit: Leaving [15:07] stroggoff (~Praetoria@2a02:587:6008:7d00:14b:35e:8c3d:689d) left irc: Quit: Leaving [15:15] ignalina (~pettersjo@h-238-27.A639.priv.bahnhof.se) left irc: Quit: ignalina [15:32] ignalina (~pettersjo@h-238-27.A639.priv.bahnhof.se) joined #scummvm. [15:53] ignalina (~pettersjo@h-238-27.A639.priv.bahnhof.se) left irc: Quit: ignalina [15:57] ny00123 (~ny00123@188.120.129.88) joined #scummvm. [15:58] _sev (~sev@scummvm/undead/sev) joined #scummvm. [15:58] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [16:19] LubomirR (d94b5cf3@gateway/web/freenode/ip.217.75.92.243) left irc: Quit: Page closed [16:19] LubomirR (~LubomirR_@bband-dyn123.178-40-119.t-com.sk) joined #scummvm. [16:23] _sev (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [16:28] _sev (~sev@scummvm/undead/sev) joined #scummvm. [16:28] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [16:37] KAT (~K4T@93.179.200.166) joined #scummvm. [16:40] KAT_ (~K4T@93.179.200.166) joined #scummvm. [16:43] waltervn (~waltervn@scummvm/undead/waltervn) joined #scummvm. [16:43] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [16:44] KAT (~K4T@93.179.200.166) left irc: Ping timeout: 276 seconds [16:45] criezy|Work (a5e15055@gateway/web/freenode/ip.165.225.80.85) left irc: Quit: Page closed [16:46] ignalina (~pettersjo@h-238-27.A639.priv.bahnhof.se) joined #scummvm. [16:50] Can somebody take a look at https://github.com/scummvm/scummvm/pull/1266 , please? [16:53] <_sev> looking [16:54] <_sev> good catch! merging [16:54] wihiterandrek (~voltage@ppp-46-33-233-188.wildpark.net) joined #scummvm. [16:54] #scummvm: mode change '+o wihiterandrek' by ChanServ!ChanServ@services. [16:54] GitHub81 (GitHub81@gateway/service/github.com/x-frzmoosmzxurezpb) joined #scummvm. [16:54] [scummvm] sev- closed pull request #1266: COMMON: Fix kerning issue in wordWrapText. (master...wordwrapfix) https://git.io/fNgdd [16:54] GitHub81 (GitHub81@gateway/service/github.com/x-frzmoosmzxurezpb) left #scummvm. [16:54] GitHub20 (GitHub20@gateway/service/github.com/x-vagftodeetkrbkwq) joined #scummvm. [16:54] [scummvm] sev- pushed 1 new commit to master: https://git.io/fN6qC [16:54] scummvm/master d9b3853 =ubomír Remák: COMMON: Fix kerning issue in wordWrapText. [16:54] GitHub20 (GitHub20@gateway/service/github.com/x-vagftodeetkrbkwq) left #scummvm. [16:55] Thanks! [16:58] KAT (~K4T@93.179.200.166) joined #scummvm. [17:02] KAT_ (~K4T@93.179.200.166) left irc: Ping timeout: 276 seconds [17:38] waltervn (~waltervn@scummvm/undead/waltervn) left irc: Quit: Leaving [17:51] ignalina (~pettersjo@h-238-27.A639.priv.bahnhof.se) left irc: Quit: ignalina [17:51] SupSuper (~SupSuper@openxcom/dev/supsuper) joined #scummvm. [17:55] _sev: One more question - at which stage would you suggest trying to merge Mutation of JB to master? I'm just asking so we can focus on those areas first. [17:57] (Assuming you accept not fully implemented engines, but if that's not the case, I'm fine with that too, it'll just be a huge PR. :-) ) [18:06] waltervn (~waltervn@scummvm/undead/waltervn) joined #scummvm. [18:06] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [18:12] GitHub146 (GitHub146@gateway/service/github.com/x-jgoieduhoihcajpo) joined #scummvm. [18:12] [scummvm] whiterandrek pushed 1 new commit to master: https://git.io/fN6Cv [18:12] scummvm/master e9fde87 whiterandrek: PINK: fixed bug when in walking state you choose another location [18:12] GitHub146 (GitHub146@gateway/service/github.com/x-jgoieduhoihcajpo) left #scummvm. [18:18] wihiterandrek (~voltage@ppp-46-33-233-188.wildpark.net) left irc: Quit: Leaving [19:07] Drenn (~Drenn@toroon0713w-lp140-02-69-157-8-46.dsl.bell.ca) joined #scummvm. [19:13] For reference (although t0by isn't around); there are some mechanisms in place in the WME persistence code to retain backwards compatibility with save games even if new fields are added, there's an entire versioning system for that. [19:13] somaen (somaen@hildring.pvv.ntnu.no) left irc: Changing host [19:13] somaen (somaen@scummvm/undead/somaen) joined #scummvm. [19:13] #scummvm: mode change '+o somaen' by ChanServ!ChanServ@services. [19:15] Old saves will get some default value for that field, and potentially not work with that particular game, but if I understand correctly, that game is broken as is. [19:16] criezy (~criezy@host86-133-88-252.range86-133.btcentralplus.com) joined #scummvm. [19:16] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services. [19:16] As for issues you're seeing, IIRC there's some placement-new magic that happens in the persistence code, so that the various pointers can be properly set up again during deserialization. This means that you'll have to set up _everything_ properly in the save/load code, for all classes that get (de)serialized [19:19] The way that works in WME, is that the Foo::persist() function is used both for save and load, your field should have an entry there to have any chance to survive a save/load-event. Potentially with a version-number guard that special-cases loading to use some default-value if the save-game version is below a particular version-number. [19:21] There, that should cover most of the issues raised, if anyone sees t0by or lb_ii, please tell point them towards the logs :) [20:30] waltervn (~waltervn@scummvm/undead/waltervn) left irc: Ping timeout: 240 seconds [20:42] <_sev> LubomirR: yes, we even welcome in-tree development [20:43] <_sev> somaen: I think, some simple gist with code or reference to existing case in master could help [20:53] _sev: Okay, does that mean I could prepare a PR with the current state? (I put some information including a video on the wiki: http://wiki.scummvm.org/index.php/MutationOfJB ) [20:56] <_sev> yes [20:57] lb_ii (5f19f288@gateway/web/freenode/ip.95.25.242.136) joined #scummvm. [20:59] somaen, this sounds to be just what we need, I totally will look at it [20:59] Awesome, thanks! [21:10] demonimin (~demonimin@unaffiliated/demonimin) left irc: Ping timeout: 268 seconds [21:17] GitHub119 (GitHub119@gateway/service/github.com/x-bnxurfxjqddvujki) joined #scummvm. [21:17] [scummvm] lolbot-iichan opened pull request #1269: COMMON: Added Ukrainian language (master...master) https://git.io/fN6P2 [21:17] GitHub119 (GitHub119@gateway/service/github.com/x-bnxurfxjqddvujki) left #scummvm. [21:29] LubomirR (~LubomirR_@bband-dyn123.178-40-119.t-com.sk) left irc: Quit: Leaving [21:46] |Cable| (~cable@249.137.117.91.dynamic.reverse-mundo-r.com) left irc: Ping timeout: 248 seconds [22:10] Dark-Star (~quassel@2a01:238:427f:2f00:3060:fc6b:969e:dcf0) left irc: Ping timeout: 256 seconds [22:11] Dark-Star (~quassel@2a01:238:427f:2f00:3060:fc6b:969e:dcf0) joined #scummvm. [22:14] lb_ii: An example of a (fairly convoluted) persist function that has a special case for game versions: https://github.com/scummvm/scummvm/blob/master/engines/wintermute/base/base_game.cpp#L3067 [22:16] Note that checkVersion() returns true for any value when saving, and is as such effectively a (isLoading && checkVersion(1,3,1)) [22:20] The pointer-deserialization stuff I mentioned happens through https://github.com/scummvm/scummvm/blob/master/engines/wintermute/base/base_persistence_manager.cpp#L828 [22:22] And the macro-magic that handles all the placement new stuff is in https://github.com/scummvm/scummvm/blob/master/engines/wintermute/persistent.h [22:25] KAT (~K4T@93.179.200.166) left irc: Ping timeout: 240 seconds [22:31] And then a lot of the deserialization magic also happens in the System-classes [22:33] ny00123 (~ny00123@188.120.129.88) left irc: Quit: Leaving [22:40] criezy (~criezy@host86-133-88-252.range86-133.btcentralplus.com) left irc: Quit: criezy [22:40] can someone answer some questions about detection tables for me? [22:41] somaen: Thanks a lot! [22:44] GitHub59 (GitHub59@gateway/service/github.com/x-hjfgmtiqdnqudrvq) joined #scummvm. [22:44] [scummvm] sev- pushed 1 new commit to master: https://git.io/fN6Ha [22:44] scummvm/master d91307e lolbot-iichan: COMMON: Added Ukrainian language... [22:44] GitHub59 (GitHub59@gateway/service/github.com/x-hjfgmtiqdnqudrvq) left #scummvm. [22:44] GitHub9 (GitHub9@gateway/service/github.com/x-aqtatlzpxqjaavtj) joined #scummvm. [22:44] [scummvm] sev- closed pull request #1269: COMMON: Added Ukrainian language (master...master) https://git.io/fN6P2 [22:44] GitHub9 (GitHub9@gateway/service/github.com/x-aqtatlzpxqjaavtj) left #scummvm. [22:45] Wooh! Here goes my first pull request ever! *^_^* [22:47] SupSuper: I have some experience with them, so let's give it a try [22:53] lb_ii [22:54] lb_ii: awesome, thank you for contributing! [22:54] thanx! [22:54] lb_ii: i guess my question is, just how detailed does variant detection need to be, and what's the advantage over just abstracting the engine from the data? [22:55] all the engines i checked had a huge matrix of platform x language x gog release x disc release x ... [22:58] I guess this still depends on engine and difference between game versions [22:59] there are some engines with detection.cpp and no detection_tables.h [23:02] hmm [23:03] i guess to get more to the point, my game has 3 main variants: Standard Performance, High Performance and Director's Cut. does this work in detection tables? [23:04] they are data differences, not platform differences, eg. both Standard and High Performance are separate installs of a DOS release [23:05] somaen: could you and/or t0by please find some time on weekend to take a look at https://github.com/lolbot-iichan/scummvm/commit/91d1047 ? I'll continue work on FoxTail next week and it would be nice to have some feedback on coding style and things done [23:11] _sev: could you please help SupSuper on detection tables? [23:16] Zaarin (~dfh@188.93.190.29) left irc: Read error: Connection reset by peer [23:16] Zaarin (~dfh@188.93.190.29) joined #scummvm. [00:00] --- Fri Aug 3 2018