[Back to Index]

[00:00] <-- ccawley2011 left irc: Ping timeout: 260 seconds
[00:36] --> GitHub168 joined #scummvm.
[00:36] <GitHub168> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vduCU
[00:36] <GitHub168> scummvm/master 9b51c1d Paul Gilbert: TITANIC: DE: Fix recognising words with common suffixes
[00:36] GitHub168 (GitHub168@192.30.252.34) left #scummvm.
[00:51] --> Cheeseness joined #scummvm.
[01:01] <-- Lightkey left irc: Ping timeout: 246 seconds
[01:06] --> GitHub127 joined #scummvm.
[01:06] <GitHub127> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vduW6
[01:06] <GitHub127> scummvm/master 6723bed Paul Gilbert: TITANIC: DE: Fixes to vocabs, strings, and font in titanic.dat
[01:06] GitHub127 (GitHub127@192.30.252.35) left #scummvm.
[01:15] --> Lightkey joined #scummvm.
[01:25] <snover> dreammaster: do you remember why you implemented ManagedSurface as a wrapper instead of a subclass?
[01:27] <dreammaster> Actually, I did it that way originally. But to get it all to work properly, I had to add the virtual addDirtyRect method to Graphics::Surface, and that apparently broke some admittantly bad code elsewhere within ScummVM that expected Graphics::Surface to be a POD class
[01:28] <dreammaster> So I had to compromise with doing it as a wrapper
[01:30] <snover> got it. thanks :)
[01:36] <-- Cheeseness left irc: Read error: Connection reset by peer
[01:38] --> DominusExult joined #scummvm.
[01:39] <dreammaster> My most recent commit bumped up the .dat version number, since there were changes to the quotes lists and strings. But I'm holding off committing in a new titanic.dat.. with me getting so close to having the German version completable, probably by the end of tomorrow, I want to make sure there won't be any further needed changes
[01:42] <-- Dominus left irc: Ping timeout: 260 seconds
[01:42] Nick change: DominusExult -> Dominus
[02:00] <-- dreammaster left irc:
[03:50] --> Cheeseness joined #scummvm.
[03:54] --> Begasus joined #scummvm.
[03:56] --> Begas_VBox joined #scummvm.
[03:56] --> GitHub60 joined #scummvm.
[03:56] <GitHub60> [scummvm] csnover pushed 23 new commits to master: https://git.io/vdu0N
[03:56] <GitHub60> scummvm/master 5e2e6e9 Colin Snover: COMMON: Switch to compile-time checking of invalid SortedArray calls...
[03:56] <GitHub60> scummvm/master 79dd023 Colin Snover: COMMON: Prevent implicit conversion of smart pointers to non-bools
[03:56] <GitHub60> scummvm/master f037d4d Colin Snover: COMMON: Allow construction of Arrays of non-copyable members...
[03:56] GitHub60 (GitHub60@192.30.252.34) left #scummvm.
[03:56] --> GitHub59 joined #scummvm.
[03:56] <GitHub59> [scummvm] criezy pushed 1 new commit to master: https://git.io/vdu0j
[03:56] <GitHub59> scummvm/master 45d1177 Thierry Crozat: I18N: Update translations templates
[03:56] GitHub59 (GitHub59@192.30.252.35) left #scummvm.

[05:17] --> Strangerke_ joined #scummvm.
[05:18] <-- Strangerke left irc: Ping timeout: 240 seconds
[05:18] Nick change: Strangerke_ -> Strangerke
[05:55] --> GitHub62 joined #scummvm.
[05:55] <GitHub62> [scummvm] csnover pushed 2 new commits to master: https://git.io/vdugN
[05:55] <GitHub62> scummvm/master ec1cfcb David Fioramonti: SCI: Add workaround for uninit read during wordsearch in castlebrain...
[05:55] <GitHub62> scummvm/master ae8e4fa Colin Snover: SCI: Add workaround for uninitialized reads in Island of Dr Brain...
[05:55] GitHub62 (GitHub62@192.30.252.35) left #scummvm.
[05:56] --> GitHub129 joined #scummvm.
[05:56] <GitHub129> [scummvm] csnover closed pull request #1032: SCI: Workaround for uninit reads during wordsearch for castlebrain (master...castlebrain_wordsearch-fix) https://git.io/vdLDG
[05:56] GitHub129 (GitHub129@192.30.252.35) left #scummvm.
[06:16] <-- Begasus left irc: Quit: Ex-Chat
[06:16] --> Begasus joined #scummvm.
[06:30] --> GitHub142 joined #scummvm.
[06:30] <GitHub142> [scummvm] csnover closed pull request #898: Update AndroidManifest.xml (master...patch-1) https://git.io/vDgVA
[06:30] GitHub142 (GitHub142@192.30.252.42) left #scummvm.
[06:45] --> GitHub12 joined #scummvm.
[06:45] <GitHub12> [scummvm] csnover closed pull request #931: SCUMM: Correctly flag demos as demos in the detection (master...master) https://git.io/vSceg
[06:45] GitHub12 (GitHub12@192.30.252.42) left #scummvm.
[06:52] <-- LittleToonCat left irc: Remote host closed the connection
[07:07] <-- Begas_VBox left irc: Quit: Vision[0.10.1]: i've been blurred!
[07:16] --> waltervn joined #scummvm.
[07:16] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[07:16] <waltervn> morning
[07:53] --> GitHub28 joined #scummvm.
[07:53] <GitHub28> [scummvm] serk12 closed pull request #934: added reverse iterator (master...master) https://git.io/vS8kT
[07:53] GitHub28 (GitHub28@192.30.252.42) left #scummvm.
[07:59] --> Begas_VBox joined #scummvm.
[08:40] --> Henke37 joined #scummvm.
[09:16] <-- Begas_VBox left irc: Quit: Vision[0.10.1]: i've been blurred!
[09:16] <-- _sev left irc: Quit: This computer has gone to sleep
[09:16] --> m_kiewitz joined #scummvm.
[09:16] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services.
[09:24] --> GitHub162 joined #scummvm.
[09:24] <GitHub162> [scummvm] m-kiewitz pushed 1 new commit to master: https://git.io/vduiA
[09:24] <GitHub162> scummvm/master 54cac32 Martin Kiewitz: Revert "SCI: Add workaround for uninitialized reads in Island of Dr Brain"...
[09:24] GitHub162 (GitHub162@192.30.252.41) left #scummvm.
[09:29] --> _sev joined #scummvm.
[09:29] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[09:52] --> Begas_VBox joined #scummvm.
[10:01] --> ny00123 joined #scummvm.
[10:52] --> GitHub81 joined #scummvm.
[10:52] <GitHub81> [scummvm] overlockeer closed pull request #935: GUI: fix for bug #9714: unnecessary tab in options (master...master) https://git.io/vS8co
[10:52] GitHub81 (GitHub81@192.30.252.35) left #scummvm.
[10:57] --> ajax16384 joined #scummvm.
[10:57] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[11:03] --> criezy joined #scummvm.
[11:03] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[11:04] --> Strangerke_ joined #scummvm.
[11:06] <-- Strangerke left irc: Ping timeout: 248 seconds
[11:06] Nick change: Strangerke_ -> Strangerke
[11:23] --> GitHub138 joined #scummvm.
[11:23] <GitHub138> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vduyo
[11:23] <GitHub138> scummvm/master 476b4a6 Paul Gilbert: DEVTOOLS: Fix UTF8 character in create_titanic
[11:23] GitHub138 (GitHub138@192.30.252.41) left #scummvm.
[11:30] <-- Begas_VBox left irc: Quit: Vision[0.10.1]: i've been blurred!
[12:13] <-- nutron|w left irc: Ping timeout: 240 seconds
[12:19] --> nutron|w joined #scummvm.
[12:25] <-- Cheeseness left irc: Quit: Leaving.
[12:34] --> Begas_VBox joined #scummvm.
[12:34] --> ignalina joined #scummvm.
[12:43] <criezy> snover: this time my OS decided to auto-correct your nick to 'snooker' :P
[12:43] <criezy> I wonder why it does an different correction each time...
[12:51] --> jamm joined #scummvm.
[12:57] --> Littleboy joined #scummvm.
[12:57] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[13:22] --> TAS-2012v joined #scummvm.
[13:23] <-- TAS_2012v left irc: Ping timeout: 258 seconds
[13:23] Nick change: TAS-2012v -> TAS_2012v
[13:23] L0ngcat (mryrobot@216.246.80.69) left #scummvm.
[13:24] --> L0ngcat joined #scummvm.
[13:48] <L0ngcat> hi everybody!
[13:53] --> girafe joined #scummvm.
[14:11] <-- ny00123 left irc: Quit: Leaving
[14:12] --> ny00123 joined #scummvm.
[15:20] --> Farmboy0 joined #scummvm.
[15:20] <-- Farmboy0 left irc: Changing host
[15:20] --> Farmboy0 joined #scummvm.
[16:20] --> LittleToonCat joined #scummvm.
[16:24] --> ccawley2011 joined #scummvm.
[16:31] <snover> criezy: 🎱
[16:42] <criezy> Hi snover
[16:42] <snover> hey!
[16:42] <criezy> And thank you for reviewing the open PR yesterday!
[16:43] <snover> youre welcome. thanks for noticing :) im going to land the window sizing stuff now and well see what happens.
[16:45] <snover> and then if that goes smoothly, look at what other ports changes are needed and what information needs to be communicated for the refactoring.
[16:56] --> GitHub72 joined #scummvm.
[16:56] <GitHub72> [scummvm] m-kiewitz pushed 1 new commit to master: https://git.io/vdzvr
[16:56] <GitHub72> scummvm/master eb1f903 Martin Kiewitz: SCI: Add script patch for Larry 1 Spanish bug #10240...
[16:56] GitHub72 (GitHub72@192.30.252.45) left #scummvm.
[17:05] --> GitHub46 joined #scummvm.
[17:05] <GitHub46> [scummvm] m-kiewitz pushed 1 new commit to master: https://git.io/vdzfm
[17:05] <GitHub46> scummvm/master 83436e6 Martin Kiewitz: SCI: Improve Larry 1 Spanish script patch...
[17:05] GitHub46 (GitHub46@192.30.252.42) left #scummvm.
[17:30] --> GitHub23 joined #scummvm.
[17:30] <GitHub23> [scummvm] csnover pushed 6 new commits to master: https://git.io/vdzJg
[17:30] <GitHub23> scummvm/master ebe6c40 Colin Snover: SDL: Do not reset window size when engines update rendering surface...
[17:30] <GitHub23> scummvm/master 432fd52 Colin Snover: ENGINES: Remove default1x scaler flag...
[17:30] <GitHub23> scummvm/master 9a82bc6 Colin Snover: SDL: Deduplicate scaling factors
[17:30] GitHub23 (GitHub23@192.30.252.45) left #scummvm.
[17:31] --> GitHub148 joined #scummvm.
[17:31] <GitHub148> [scummvm] criezy pushed 1 new commit to master: https://git.io/vdzJ2
[17:31] <GitHub148> scummvm/master a475295 Thierry Crozat: I18N: Update translations templates
[17:31] GitHub148 (GitHub148@192.30.252.41) left #scummvm.
[17:32] --> GitHub38 joined #scummvm.
[17:32] <GitHub38> [scummvm] csnover closed pull request #1007: SDL: Do not reset window size when engines update rendering surface (master...stickier-window-size) https://git.io/v5EG5
[17:32] GitHub38 (GitHub38@192.30.252.42) left #scummvm.
[17:33] <snover> woo! now to cross fingers that this doesnt explode the ports on buildbot :)
[17:33] <snover> and if not, then update some docs.
[17:39] wjp crosses fingers :-)
[17:44] <snover> ios7 exploded in an& unexpected manner. what is going on here&
[17:46] <wjp> sorry, I uncrossed my fingers for a moment there
[17:46] <snover> :)
[17:47] <snover> its having some explosion related to `typedef Common::Array<Mode> ModeList`
[17:47] <snover> i wonder if Mode is some macro&
[17:50] <snover> nope. that seemed a little too weird anyway
[17:53] <wjp> are we looking at the same error?
[17:53] <wjp> This one seems to point at ABS being a macro
[17:53] <wjp> http://buildbot.scummvm.org/builders/master-ios7/builds/4659/steps/compile/logs/stdio
[17:53] <snover> yeah, that is the one
[17:54] <wjp> the line in the sources is template<typename T> inline T ABS(T x) { return (x >= 0) ? x : -x; }
[17:54] <wjp> and the compiler error is saying: template<typename T> inline T ((T x) < 0 ? (-(T x)) : (T x)) { return (x >= 0) ? x : -x; }
[17:54] <snover> oh, oh. yes. ok.
[17:54] <snover> well at least i got the macro part right&
[17:55] <ScummBot> Port build status changed with 04f357e6: Failure: master-ios7
[17:55] <snover> i was a little confused by the code but my brain was not registering what was actually going on
[17:56] <snover> i dont know where i managed to get confused to think it was due to anything in mode.h
[18:01] <wjp> template and macro expansion combined is always fun... :-)
[18:03] <wjp> and Mode is the thing that actually changed in this vicinity in this merge I suppose
[18:03] --> GitHub104 joined #scummvm.
[18:03] <GitHub104> [scummvm] csnover pushed 1 new commit to master: https://git.io/vdzTg
[18:03] <GitHub104> scummvm/master 914bb1b Colin Snover: COMMON: Undefine ABS if it is a macro...
[18:03] GitHub104 (GitHub104@192.30.252.41) left #scummvm.
[18:03] <exmensa> Is there a specific place to report unrecognized game versions, or do I just put them here?
[18:04] <snover> since i didnt see any symbol name for the templated function since it was getting blown away by the macro, i looked through the list of includes and saw the only new usage of a templated argument was in mode.h, so incorrectly concluded that it had to do with that
[18:04] <snover> i think that was the thought process.
[18:05] <wjp> exmensa: could you file a bug report at https://bugs.scummvm.org/ ?
[18:05] <exmensa> Will do, thanks!
[18:08] --> GitHub179 joined #scummvm.
[18:08] <GitHub179> [scummvm] csnover pushed 1 new commit to master: https://git.io/vdzTD
[18:08] <GitHub179> scummvm/master 6419178 Colin Snover: SCUMM: Fix compilation on systems without USE_RGB_COLOR
[18:08] GitHub179 (GitHub179@192.30.252.41) left #scummvm.
[18:16] <ScummBot> Port build status changed with 04f357e6: Failure: master-n64
[18:26] <wjp> exmensa: thanks!
[18:27] <exmensa> Sure thing :)
[19:02] --> Strangerke_ joined #scummvm.
[19:04] <-- Strangerke left irc: Ping timeout: 240 seconds
[19:04] Nick change: Strangerke_ -> Strangerke
[19:15] <-- ignalina left irc: Quit: ignalina
[19:17] <ScummBot> Port build status changed with 04f357e6: Failure: master-ds
[19:27] --> abrcdbr joined #scummvm.
[19:35] --> Strangerke_ joined #scummvm.
[19:35] <-- ajshell1 left irc: Quit: Leaving
[19:35] <-- Strangerke left irc: Ping timeout: 264 seconds
[19:35] Nick change: Strangerke_ -> Strangerke
[19:36] --> dreammaster joined #scummvm.
[19:36] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[19:36] <snover> wjp: any chance you will have time to peek at https://github.com/scummvm/scummvm/pull/1034 soonish?
[19:42] <-- ludde left irc: Ping timeout: 255 seconds
[19:43] --> ignalina joined #scummvm.
[19:45] --> ludde joined #scummvm.
[19:52] <-- ludde left irc: Ping timeout: 260 seconds
[19:52] --> ludde joined #scummvm.
[19:53] --> GitHub89 joined #scummvm.
[19:53] <GitHub89> [scummvm] csnover pushed 2 new commits to master: https://git.io/vdzmU
[19:53] <GitHub89> scummvm/master 1b669d2 Colin Snover: SCI: Add workaround for uninitialized reads in Island of Dr Brain...
[19:53] <GitHub89> scummvm/master 7d03749 Colin Snover: SCI: Use explicit indexes in castlebrain/islandbrain word search workarounds
[19:53] GitHub89 (GitHub89@192.30.252.42) left #scummvm.
[19:53] <-- tsoliman left irc: Quit: I've been banished!
[19:53] <m_kiewitz> snover: I'm just changing this to a index range
[19:54] <snover> ok. in my testing it seems to be only the two indexes in this case. i am not sure if a range will solve the problem for some of the other workarounds which seem to be like&many different indexes
[19:54] <snover> non-contiguous
[19:55] <m_kiewitz> well for the very few exceptions, we can simply specify a full range
[19:55] <m_kiewitz> like the AI code in crazy nick
[19:55] <m_kiewitz> im going through those one by one
[19:56] --> tsoliman joined #scummvm.
[19:56] #scummvm: mode change '+o tsoliman' by ChanServ!ChanServ@services.
[19:56] <snover> this hoyle4 one looks like a programming nightmare: when placing a bid in bridge (always), temp var 11, 24, 27, 46, 75, objects compete_tree, compwe_tree, other1_tree, b1
[19:59] <m_kiewitz> yes, for this case an automatic detection would be very useful
[19:59] <m_kiewitz> i wouldn't be surprised in case maybe the AI gets downgraded by using doing it
[20:00] <m_kiewitz> maybe some temp was used for some random behavior, who knows
[20:00] <m_kiewitz> or maybe it got upgraded instead
[20:00] <m_kiewitz> crazy nick and hoyle are both nightmares
[20:00] <m_kiewitz> I wonder if Sierra used interns for those
[20:06] <-- jamm left irc: Ping timeout: 258 seconds
[20:08] --> ajshell1 joined #scummvm.
[20:10] <ScummBot> Port build status changed with 04f357e6: Failure: master-caanoo, master-debian-x86-nullbackend, master-gp2x, master-dingux
[20:10] --> GitHub91 joined #scummvm.
[20:10] <GitHub91> [scummvm] m-kiewitz pushed 1 new commit to master: https://git.io/vdzmF
[20:10] <GitHub91> scummvm/master 60c2c28 Martin Kiewitz: SCI: Change index inside workaround tables to an index range...
[20:10] GitHub91 (GitHub91@192.30.252.35) left #scummvm.
[20:13] <m_kiewitz> hmm the rats code inside kq6 looks as if it would even need patching
[20:14] <-- ajax16384 left irc: Read error: Connection reset by peer
[20:19] <snover> i guess i am a little uncertain of the benefit if it is working already
[20:25] --> GitHub166 joined #scummvm.
[20:25] <GitHub166> [scummvm] csnover pushed 1 new commit to master: https://git.io/vdzYN
[20:25] <GitHub166> scummvm/master 20bd289 Colin Snover: BACKENDS: Remove references to old normal1xScaler transaction property from ports
[20:25] GitHub166 (GitHub166@192.30.252.42) left #scummvm.
[20:27] <snover> ok, that breakage wasnt too bad. hopefully everything is fixed up on the next build. too bad that ios7 issue modified a common system header, itll be another while for the builds to run again.
[20:30] <m_kiewitz> that's actually the question - I'm not entirely sure if the rats are currently doing what they are supposed to do
[20:30] <snover> ah, i see.
[20:30] <m_kiewitz> and i seems to be visual only
[20:33] <ScummBot> Port build status changed with 04f357e6: Failure: master-ps2, master-gcw0, master-gp2xwiz
[20:34] <-- ajshell1 left irc: Quit: Leaving
[20:37] --> GitHub164 joined #scummvm.
[20:37] <GitHub164> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vdzOO
[20:37] <GitHub164> scummvm/master 76e5a02 Paul Gilbert: TITANIC: DE: Fix Barbot response handling
[20:37] GitHub164 (GitHub164@192.30.252.34) left #scummvm.
[20:42] <exmensa> snover: I'd checked for the version file, but I didn't see anything that looked like one. I've uploaded the contents of the CD, and FWIW it's one of the releases that came with the soundtrack CD and is recognized/runs properly other than the detection message.
[20:44] <snover> exmensa: can you tell me the full hashes (md5/sha/whatever) of resource.000 and resource.map?
[20:44] <snover> the file sizes and dates are identical to mine so im concerned there is another detection bug
[20:44] <exmensa> Sure thing, one sec
[20:47] --> ajshell1 joined #scummvm.
[20:47] <-- ajshell1 left irc: Client Quit
[20:49] <snover> welp.
[20:49] <snover> those *are* the files corresponding to the existing detection table entry.
[20:49] <exmensa> :(
[20:50] <snover> the fact that it is saying things about e.scn and demarchg.vmd makes me wonder what is going on
[20:50] <snover> let me see what happens here with my all-engines-enabled build.
[20:51] <exmensa> That was with current daily win64, forgot that in the bug
[20:51] <wjp> e.scn is playtoons, apparently?
[20:52] <snover> doh.
[20:52] --> GitHub128 joined #scummvm.
[20:52] <GitHub128> [scummvm] JenniBee closed pull request #808: WINTERMUTE: Add flag for games using low-spec resources (master...master) https://git.io/v6a97
[20:52] GitHub128 (GitHub128@192.30.252.34) left #scummvm.
[20:52] <snover> i guess its time for the AdvancedAdvancedGameDetector
[20:53] <wjp> interestingly that demarchg.vmd filesize matches the one of the playtoons1 non-interactive demo according to gob/detection/tables_playtoons.h
[20:53] <wjp> I wonder if that e.exe actually _is_ that demo
[20:54] <snover> id believe it.
[20:54] <wjp> the e.scn filesize does not match
[20:55] <wjp> so this may be an unrecognized playtoons demo rather than an unrecognized mgdx :-)
[20:55] --> ajshell1 joined #scummvm.
[20:55] <-- Littleboy left irc: Ping timeout: 248 seconds
[20:55] <snover> perhaps it would be a good idea to add the name of the engine that thinks its detecting something
[20:55] <exmensa> It does have a playtoons Archibald ad on the rear of the jewelcase :)
[20:56] <wjp> snover: that does sound like a good idea
[20:57] <snover> // TODO: This message should be cleaned up / made more specific.
[20:57] <snover> // For example, we should specify at least which engine triggered this.
[20:57] --> macdude22 joined #scummvm.
[20:59] <-- macdude22 left irc: Client Quit
[21:03] --> macdude22 joined #scummvm.
[21:04] <-- macdude22 left irc: Client Quit
[21:05] --> macdude22 joined #scummvm.
[21:06] <-- macdude22 left irc: Client Quit
[21:06] --> abrcdbr_ joined #scummvm.
[21:08] <-- abrcdbr left irc: Ping timeout: 240 seconds
[21:09] <t0by> snover: regarding your comment on the PR that has just been closed, I don't think it's *very much* worth it. AS you can see I myself don't even have time to get on IRC currently and WME support hasn't even been rolled out officially. Supporting a game made *by* the PR author on a niche platform is cool, _but_ not something I'd invest time on personally.
[21:09] <t0by> Not now, at least :|
[21:10] <ScummBot> Port build status changed with 76e5a024: Success: master-ios7
[21:14] <-- Farmboy0 left irc: Remote host closed the connection
[21:16] <-- ajshell1 left irc: Quit: Leaving
[21:17] <snover> t0by: but you *are* going to move around the interpolation code for me right? RIGHT? ;)
[21:18] <snover> wjp: as long as im here, should i put a link to the bug tracker in the message too?
[21:19] <t0by> snover: eventually, yes, if nobody beats me on time. Historically, I've always used the excuse that I have little time. This couple of months, it's even worse. Sorry, really.
[21:19] <snover> no worries, i am in no hurry.
[21:19] <-- phyber left irc: Ping timeout: 240 seconds
[21:27] --> GitHub193 joined #scummvm.
[21:27] <GitHub193> [scummvm] JenniBee reopened pull request #808: WINTERMUTE: Add flag for games using low-spec resources (master...master) https://git.io/v6a97
[21:27] GitHub193 (GitHub193@192.30.252.35) left #scummvm.
[21:27] <t0by> It's back!
[21:31] <t0by> Allow me to be blunt and perhaps a bit of a dick: I am not sure that adding stuff to support the patch author's fangame(s) is *that much* meaningful. I can't articulate why, but it rubs me slightly the wrong way. I think they might rather want to fork the engine and distribute it along with the game. OTOH it's just a few lines and no-one will probably get hurt.
[21:31] <t0by> So well, that's not really an objection, but a raised eyebrow from me.
[21:31] --> ajshell1 joined #scummvm.
[21:32] <t0by> If this means that the author will get on board and help fix bugs, on the other hand... :)
[21:34] <snover> at the end of the day it is up to you, if the only absolutely required change is to add a flag to start with the correct resolution then that seems like a balanced approach
[21:35] <ScummBot> Port build status changed with 76e5a024: Success: master-n64
[21:42] <-- ced117 left irc: Ping timeout: 246 seconds
[21:43] --> ced117 joined #scummvm.
[21:44] <-- ajshell1 left irc: Quit: Leaving
[21:48] <t0by> I'm just not sure that we want to create a precedent: the game's website says that "it is intended to be a template for anyone to create their own adventures to run on the Dreamcast (or any platform that ScummVM supports)", i.e. sounds like a solution in search of a problem to me. I am okay with the changes, though. Were it for me I'd hit the "merge" button, with my eyebrow well raised.
[21:48] <t0by> I just found that I wanted to share my (minor) concern.
[21:50] <t0by> If nobody else is concerned by this, I'll try to review and merge this week.
[21:53] --> phyber joined #scummvm.
[21:54] <snover> i mean. its not an engine i maintain, but i would say the low-res flag seems fine but removing the required library dependencies and adding ifdefs and runtime errors seems unnecessary (these are not exactly esoteric library dependencies). also there is at least one logic bug here where `else if` has been turned into `if` when doing audio file suffix checks
[22:04] <-- Begas_VBox left irc: Quit: Vision[0.10.1]: i've been blurred!
[22:08] <t0by> snover: thanks for the heads up. I haven't had the time to look at it closely, I was still at the "philosophical objections" stage.
[22:12] --> ajshell1 joined #scummvm.
[22:12] <fuzzie> I assume the libraries are considered too large for the memory-constrained targets
[22:14] <snover> the OP said the dreamcast target has been dropped from the patch, so i am not sure what other targets those would be
[22:16] <fuzzie> well, there are some :) but might be worth asking if there is a goal in mind
[22:18] <-- ajshell1 left irc: Quit: Leaving
[22:20] <fuzzie> (but I was just sort of reacting to the "not exactly esoteric" in a bit of an out-of-context way because I hadn't realised our Dreamcast port doesn't expose 16bpp support)
[22:30] <-- Begasus left irc: Quit: Ex-Chat
[22:49] <ScummBot> Port build status changed with 76e5a024: Success: master-ds
[22:55] <-- ny00123 left irc: Quit: Leaving
[22:57] <-- girafe left irc: Read error: Connection reset by peer
[23:01] <-- t0by left irc: Ping timeout: 240 seconds
[23:05] <-- criezy left irc: Quit: criezy
[23:07] --> ajshell1 joined #scummvm.
[23:07] <-- waltervn left irc: Quit: Leaving
[23:11] <-- ajshell1 left irc: Client Quit
[23:13] <-- m_kiewitz left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray.
[23:26] --> ajshell1 joined #scummvm.
[23:26] --> macdude22 joined #scummvm.
[23:27] <-- macdude22 left irc: Client Quit
[23:27] --> t0by joined #scummvm.
[23:27] #scummvm: mode change '+o t0by' by ChanServ!ChanServ@services.
[23:32] --> macdude22 joined #scummvm.
[23:32] <-- macdude22 left irc: Client Quit
[23:36] <-- ignalina left irc: Quit: ignalina
[23:37] <-- ccawley2011 left irc: Quit: Page closed
[23:45] --> macdude22_baseme joined #scummvm.
[23:55] <-- Henke37 left irc: Quit: ERR_SHUTDOWN
[00:00] --- Sun Oct 8 2017