ScummVM IRC Log - 09 Sep 2016

[Back to Index]

[00:03] <movAX13h> sluicebox, right, I tried it now with fullscreen switch and -g1x. the touch input does not work properly in fullscreen mode though.

[00:05] <movAX13h> the cursor jumps to the corners... seems uncontrollable
[00:07] <sluicebox> oh, i was responding to m_kiewitz
[00:12] <movAX13h> oh :) sorry...
[00:12] movAX13h (ice@178-191-27-129.adsl.highway.telekom.at) left #scummvm.
[00:18] <-- m_kiewitz left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray.
[00:26] <-- sluicebox left irc: Remote host closed the connection
[01:16] <-- waltervn left irc: Quit: Leaving
[01:44] --> Vampire0_ joined #scummvm.
[01:46] <-- Henke37 left irc: Quit: ERR_SHUTDOWN
[01:48] <-- Vampire0 left irc: Ping timeout: 255 seconds
[02:48] <-- snover left irc: Quit: Leaving.
[03:08] <-- dreammaster left irc:
[04:00] <-- Cheeseness left irc: Quit: Leaving.
[04:03] --> Cheeseness joined #scummvm.
[05:38] <-- Cruel` left irc: Quit: Leaving
[06:25] --> ny00123 joined #scummvm.
[06:31] --> Strangerke joined #scummvm.
[06:32] <cpasjuste> hi
[06:34] <-- Strangerke_ left irc: Ping timeout: 276 seconds
[06:34] Nick change: Strangerke -> Strangerke_
[06:38] --> WooShell joined #scummvm.
[06:39] <WooShell> good meowning =^.^=
[06:46] <-- klusark left irc: Ping timeout: 252 seconds
[06:47] <_sev> hi cpasjuste
[06:48] --> klusark joined #scummvm.
[07:13] <-- TMM left irc: Quit: Ex-Chat
[07:22] --> t0by joined #scummvm.
[07:22] #scummvm: mode change '+v t0by' by ChanServ!ChanServ@services.
[07:31] <wanwan> link to Buried engine is broken on the wiki
[07:32] --> m_kiewitz joined #scummvm.
[07:32] <-- m_kiewitz left irc: Changing host
[07:32] --> m_kiewitz joined #scummvm.
[07:32] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services.
[07:39] <-- TAS_2012v left irc:
[08:04] Nick change: Vampire0_ -> Vampire0
[08:10] --> Strangerke|work joined #scummvm.
[08:46] --> _sev|work joined #scummvm.
[08:46] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[08:59] --> GitHub75 joined #scummvm.
[08:59] <GitHub75> [scummvm] sev- pushed 1 new commit to master: https://git.io/vi4V1
[08:59] <GitHub75> scummvm/master 96e4187 Eugene Sandulenko: FULLPIPE: Further work on scene27 bats knocking logic
[08:59] GitHub75 (GitHub75@192.30.252.46) left #scummvm.
[09:00] <-- Lightkey left irc: Ping timeout: 255 seconds
[09:13] --> Lightkey joined #scummvm.
[09:24] --> Strangerke|work_ joined #scummvm.
[09:27] <-- Strangerke|work left irc: Ping timeout: 264 seconds
[09:43] --> Dominus joined #scummvm.
[09:43] <-- Dominus left irc: Changing host
[09:43] --> Dominus joined #scummvm.
[09:47] --> Strangerke|work joined #scummvm.
[09:47] <-- Strangerke|work_ left irc: Ping timeout: 264 seconds
[10:00] --> TMM joined #scummvm.
[10:04] <-- TMM left irc: Client Quit
[10:22] --> Henke37 joined #scummvm.
[10:34] --> waltervn joined #scummvm.
[10:34] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[10:37] --> TMM joined #scummvm.
[12:30] <-- waltervn left irc: Quit: Leaving
[12:34] <t0by> If anybody has spare money, the rights for Toonstruck are for sale, apparently: https://twitter.com/InfoSecMiku/status/774169276441767936/photo/1
[12:46] <Strangerke|work> I'd be interested by Stonekeep if the sources are provided
[12:46] <Strangerke|work> Kingdom could be cool too, it's a low hanging fruit
[13:11] --> Littleboy joined #scummvm.
[13:11] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[13:48] --> TAS_2012v joined #scummvm.
[14:55] --> Cruel` joined #scummvm.
[15:03] <-- TMM left irc: Ping timeout: 244 seconds
[15:06] --> snover joined #scummvm.
[15:06] #scummvm: mode change '+o snover' by ChanServ!ChanServ@services.
[15:11] --> TMM joined #scummvm.
[15:13] --> WinterGrascph joined #scummvm.
[15:13] #scummvm: mode change '+v WinterGrascph' by ChanServ!ChanServ@services.
[15:32] <-- TMM left irc: Quit: Ex-Chat
[15:45] --> WinterGrascph_ joined #scummvm.
[15:45] #scummvm: mode change '+v WinterGrascph_' by ChanServ!ChanServ@services.
[15:47] <-- WinterGrascph left irc: Ping timeout: 240 seconds
[15:49] <-- FreeTHX left irc: Ping timeout: 244 seconds
[15:50] --> ajax16384 joined #scummvm.
[15:50] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[15:50] --> girafe joined #scummvm.
[15:53] <-- Deledrius left irc: Quit: App.Exit
[15:56] --> Deledrius joined #scummvm.
[16:10] <-- _sev|work left irc: Quit: This computer has gone to sleep
[16:12] <-- Strangerke|work left irc: Quit: Page closed
[16:28] <snover> ugh, phantasmagoria. `IntArray:newWith(4 "")`
[16:28] <snover> new integer array, then tries to set the first element to an empty string reference
[16:29] <snover> ugh. sq6 does it in 4 scripts too.
[16:35] <-- klusark left irc: Quit: quit
[16:40] --> klusark joined #scummvm.
[16:53] <snover> m_kiewitz: is there documentation somewhere about how to write patches other than the brief comments in script_patches.cpp?
[16:54] <m_kiewitz> it's quite simple and script_patches.cpp contains quite a few comments on it too
[16:54] <m_kiewitz> you got any questions?
[17:01] <snover> it looks like patches can be shorter than the signature, is this correct?
[17:03] <m_kiewitz> yes
[17:03] <m_kiewitz> and you can of course also skip bytes, the patch is supposed to be as short as possible
[17:05] <m_kiewitz> patches can also get bytes from the original, and even add or subtract a certain amount as well
[17:06] --> TMM joined #scummvm.
[17:08] <snover> is there a way to inspect the final patched code to make sure the patch is applying in the expected way?
[17:08] <m_kiewitz> i just go through it via debugger
[17:08] <snover> ok
[17:08] <m_kiewitz> you should do that in any case just in case you miss something
[17:09] <m_kiewitz> a script byte code inspection opcode in the debugger would be nice though
[17:09] <m_kiewitz> i think we got a disassembler opcode, but afaik only for whole scripts
[17:09] <m_kiewitz> eh not opcode, but rather command
[17:14] <snover> i ran disasm_addr
[17:17] <snover> i think this is almost, but not quite, correct
[17:17] <snover> is there a specific way to add noops?
[17:18] <m_kiewitz> there are no true NOPs in SCI at least afaik
[17:18] <m_kiewitz> i use ldi 0 or something like that
[17:18] <m_kiewitz> can take up 2 or 3 bytes
[17:19] <m_kiewitz> and in case i need to waste 1 byte only, i will just extend a jump or a pushi or something like that to use 3 bytes instead of 2
[17:19] <m_kiewitz> by well simply using a word as parameter instead of a byte
[17:20] <m_kiewitz> what's the most important part about patches is to document everything properly. We have a few script patches were that wasn't done
[17:20] <snover> thats great advice, and would be very useful in the documentation
[17:20] <m_kiewitz> and well of course testing them again several versions especially translated versions
[17:21] <m_kiewitz> well, that's rather a VM trick. there are also quite a few optimization tricks that i learnt over time
[17:21] <m_kiewitz> the SCI compiler didn't do a perfect job (thank god for that)
[17:26] <snover> i dont suppose there is something like SIG_SELECTOR16 but for class names?
[17:27] <snover> https://gist.github.com/csnover/a10305ef34665ffd35afc3980f59f3a3 the hard-codedness of the string address and the class number make this patch brittle
[17:32] --> _sev|work joined #scummvm.
[17:32] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[17:33] --> GitHub136 joined #scummvm.
[17:33] <GitHub136> [scummvm] sev- pushed 3 new commits to master: https://git.io/viBKh
[17:33] <GitHub136> scummvm/master 4fc6f02 Eugene Sandulenko: FULLPIPE: Make calculation in scene27 more readable
[17:33] <GitHub136> scummvm/master 7865308 Eugene Sandulenko: FULLPIPE: Fix bat knocking in scene27
[17:33] <GitHub136> scummvm/master 92b22b4 Eugene Sandulenko: FULLPIPE: More debug output to scene27
[17:33] GitHub136 (GitHub136@192.30.252.46) left #scummvm.
[17:33] <-- _sev|work left irc: Client Quit
[17:34] <m_kiewitz> nope
[17:35] <m_kiewitz> im also not sure if patching those things is the "proper" way. Because you would then have to patch all sorts of games
[17:35] <snover> two games
[17:35] <m_kiewitz> what did the original code do in that case? write a 0 to it? or the offset of the string?
[17:37] <m_kiewitz> also i'm not sure if that offset stayed the game for all the various versions
[17:41] --> FreeTHX joined #scummvm.
[17:50] <snover> if i am reading this correctly& it looks like it would read the string as a short array instead of a char array so it would get some garbage
[17:53] <-- WinterGrascph_ left irc: Read error: Connection reset by peer
[17:53] --> WinterGrascph joined #scummvm.
[17:53] #scummvm: mode change '+v WinterGrascph' by ChanServ!ChanServ@services.
[17:59] --> WinterGrascph_ joined #scummvm.
[17:59] #scummvm: mode change '+v WinterGrascph_' by ChanServ!ChanServ@services.
[18:00] <-- WinterGrascph left irc: Ping timeout: 276 seconds
[18:05] <-- TAS_2012v left irc:
[18:07] --> TAS_2012v joined #scummvm.
[18:12] #scummvm: mode change '+o Strangerke_' by ChanServ!ChanServ@services.
[18:19] <-- Deledrius left irc: Ping timeout: 264 seconds
[19:00] --> criezy joined #scummvm.
[19:00] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[19:02] <snover> ah. i found a better representation of this patch. works for both games. luckily the bug calls to a system class which seems to always have the same class number.
[19:03] <snover> it appears that the places where this bad call is were all arrays intended to be text size rectangles.
[19:06] --> frankyboy_ joined #scummvm.
[19:29] --> SylvainTV joined #scummvm.
[19:29] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[19:33] <-- WinterGrascph_ left irc: Remote host closed the connection
[19:33] --> WinterGrascph_ joined #scummvm.
[19:33] #scummvm: mode change '+v WinterGrascph_' by ChanServ!ChanServ@services.
[19:56] --> GitHub185 joined #scummvm.
[19:56] <GitHub185> [scummvm-tools] criezy pushed 1 new commit to master: https://github.com/scummvm/scummvm-tools/commit/60033c92740ba63850911dea3f6946c5c9e38b9f
[19:56] <GitHub185> scummvm-tools/master 60033c9 Thierry Crozat: BUILD: Fix build on newlib-based systems
[19:56] GitHub185 (GitHub185@192.30.252.45) left #scummvm.
[19:59] <-- WinterGrascph_ left irc: Remote host closed the connection
[20:00] --> WinterGrascph_ joined #scummvm.
[20:00] #scummvm: mode change '+v WinterGrascph_' by ChanServ!ChanServ@services.
[20:33] <snover> should I put AGDF_CD flags on games that had no floppy version, only CD?
[20:34] <snover> the existing games are inconsistent in this regard
[20:37] <-- frankyboy_ left irc: Remote host closed the connection
[20:41] <m_kiewitz> snover: which are?
[20:41] <m_kiewitz> CD versions should always have AGDF_CD
[20:45] <snover> GK2, Hoyle 5, LSL6 hires, LSL7, probably more&
[20:46] <snover> those are ones that came on CD without the CD flag
[20:46] <snover> But except for Hoyle I dont think any of these had floppy versions.
[20:47] <snover> so im not sure what the point of putting a CD flag on them is
[20:47] <m_kiewitz> Hoyle 5 actually comes on CD + floppy as well
[20:47] <snover> others like KQ7 and Torin do have the CD flag set
[20:47] <m_kiewitz> i got a copy on ebay.com, dreammaster will forward it to me at some point. I will then check which are CD exclusive (if there are any)
[20:47] <snover> thats why I said except for Hoyle :)
[20:48] <m_kiewitz> well there could be one version that was on CD only
[20:48] <m_kiewitz> GK2, etc. that's incorrect
[20:55] <snover> okeydokey.
[20:56] <m_kiewitz> i need to get my hands on hoyle 5. It's a shame, I ordered 2 and wanted to send you a copy. And that copy got lost, because I - dumbass - forgot to add dreammaster's house number
[20:57] <m_kiewitz> funnily the other order arrived. But the original one said "delivered", but wasn't there. I guess the USPS guy just dropped it into some trash can :/
[21:03] <snover> weird. i feel like they normally hold the mail at the local postal office in cases like that, but maybe im just too optimistic about these things :)
[21:03] <snover> i wonder where it ended up
[21:06] <m_kiewitz> i would have expected the tracking to say "incomplete address, checking with sender" or "returning to sender", but nope.
[21:11] <-- ny00123 left irc: Quit: Leaving
[21:21] --> Polynomial-C joined #scummvm.
[21:29] <-- Littleboy left irc: Read error: Connection reset by peer
[21:29] --> Littleboy joined #scummvm.
[21:29] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[21:40] --> WinterGrascph joined #scummvm.
[21:40] #scummvm: mode change '+v WinterGrascph' by ChanServ!ChanServ@services.
[21:41] <-- WinterGrascph_ left irc: Read error: Connection reset by peer
[21:49] --> WinterGrascph_ joined #scummvm.
[21:49] #scummvm: mode change '+v WinterGrascph_' by ChanServ!ChanServ@services.
[21:50] <-- WinterGrascph left irc: Read error: Connection reset by peer
[21:56] <-- girafe left irc: Read error: Connection reset by peer
[21:57] <-- t0by left irc: Quit: Bye!
[21:59] <-- ajax16384 left irc: Read error: Connection reset by peer
[22:12] <-- demonimin_ left irc: Ping timeout: 276 seconds
[22:32] <-- WinterGrascph_ left irc: Ping timeout: 244 seconds
[22:37] <-- WooShell left irc: Quit: Zu gotdy od mpy nrmy stpimf. Zu drvpmf zrsmd aogy jrt iq pt viy jrt yp yjr htpimf.
[22:55] <-- m_kiewitz left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray.
[23:51] <-- Henke37 left irc: Quit: ERR_SHUTDOWN
[00:00] --- Sat Sep 10 2016