[00:13] dafioram (~dafioram@172.56.2.28) joined #scummvm. [00:14] snover: did you see my question from this morning? [00:15] dafioram: yes. so i think you added the selector not at the same indexes in the enum and the array at the top of script_patches.cpp? [00:15] they have to be in both, and at the same index in both [00:19] otherwise from what i saw, what you did should work [00:20] Cheeseness (~cheesenes@ppp14-2-185-141.bras1.hba2.internode.on.net) joined #scummvm. [00:23] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) left irc: Quit: ERR_SHUTDOWN [00:23] It looks like they are in the same place to me https://imgur.com/a/SYAOQ [00:24] i do not see fade in that screenshot in the selectorNameTable array [00:24] i see newRoom [00:24] yes [00:25] and (1) youre using PATCH_SELECTOR16(fade), not PATCH_SELECTOR16(newRoom), (2) "fade" is not in selectorNameTable, only "newRoom" is in selectorNameTable. [00:26] okay its function newRoom that is disasm, but its the fade function that I am trading for a play [00:27] yes [00:27] well [00:27] in the opposite order :) [00:27] yeah [00:28] one of the minor changes that needs to be made is to also match the play selector in the signature using SIG_SELECTOR8(play) instead of the literal value [00:28] but that will not affect whether or not this works on your system [00:28] dreammaster (~dreammast@c-73-149-116-247.hsd1.vt.comcast.net) left irc: [00:29] why [00:29] why does it need to change, or why wont it affect whether it works? [00:29] why is it better then literal [00:30] sometimes, a different version or localisation of a game will change the selector vocabulary, so e.g. the 'play' selector in one version is 0x33 and in another version is 0x63 or some other number. [00:31] when this happens, the same script bugs usually exist, so we still want to apply the patch to those other versions if it matches. [00:31] opcodes are different? [00:31] the selector numbers (the operands) are different, the opcodes (operators) are the same [00:33] the selectors come from a special vocab 997 resource, so using *_SELECTOR8/16 allows the script patcher to look up the selectors from the vocab file instead of using hard-coded values which arent always the same [00:34] this doesnt happen too frequently in SCI32 compared to SCI16, but it did happen with at least one of the Torin localisations, so SCI32 is not immune to this situation. [00:36] my change was bad again where the new play should be it says 38 ff ff (pushi ffff) [00:38] In the array I have "fade" after "view" and in the enum I have SELECTOR_fade after SELECTOR_View [00:40] did you also make sure to add/remove play/newRoom selectors so theyre all matching up? [00:42] i didn't use patch selector for newRoom, but I still need it? [00:43] I currently dont have it in [00:43] no, but it needs to be removed from both of the places it was added, or the lists wont match again [00:44] only fade is in [00:44] ok. one moment. [00:45] any chance that the patch selector replacement is really ffff and thats not correct? [00:46] nope, 0xFFFF is -1 is invalid selector [00:46] ouch [00:46] could you run `git diff` and pastebin that somewhere so i can look at it? [00:48] https://pastebin.com/DY9E67iK [00:49] dreammaster (~dreammast@c-73-149-116-247.hsd1.vt.comcast.net) joined #scummvm. [00:49] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [00:50] dafioram: this file wont compile, you are missing a , after "fade" [00:50] or actually [00:50] thats a lie [00:50] it will combine the two strings together [00:50] "fadetest" [00:51] lets try again [00:54] looks good [00:54] awesome! [00:55] what happens if duplicate selector name for say 2 different games? [00:57] do we just not add another entry for the enum and array? [00:57] its the same selector name used in two different games. it doesnt matter how many games use them. as you can see from some of the comments in selectorNameTable, many of these selectors are either system selectors or used in multiple games [00:57] (system selector = used in *all* the games) [00:58] no get [00:58] ScriptPatcherSelectors is used for lookups into selectorNameTable which are then used to query the selector vocab from the kernel. [01:00] abrcdbr_ (~abrcdbr@159.224.109.206) joined #scummvm. [01:01] abrcdbr_ (~abrcdbr@159.224.109.206) left irc: Client Quit [01:02] ignalina (~pettersjo@h-238-36.A639.priv.bahnhof.se) left irc: Quit: ignalina [01:02] abrcdbr (~abrcdbr@159.224.109.206) left irc: Ping timeout: 240 seconds [01:03] Why isnt the first byte for the signature and patch the same? [01:04] I think its because one is a 2 byte pushi and one is a 1 byte pushi [01:05] you are correct [01:05] do those need to be wrapped also? [01:06] no [01:06] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 260 seconds [01:07] Dominus (~dominus@unaffiliated/dominus) joined #scummvm. [01:14] Hmmm.. there seems to be a problem a problem with IDA 7.0 which I just installed. None of my existing IDBs will open.. it says that 'metapc' is not one of the installed processor types. Nor can I open fresh executables without the same error [01:14] Can anyone else confirm this? I have a sinking suspicion that they simply dropped the PC processor module from the IDA Starter version :( [01:15] that would seem odd. let me see what i can do. [01:17] oh. my virtual machine is 32-bit so i could run 16-bit installers, so i can't do much to verify this or not in the 64-bit version. [01:18] i'll try the 32-bit version but it sounds like they did not make any of the actual changes to it. [01:18] It'd be pretty odd if they did. I mean, IDA Starter is meant to be a light "starter" version. Why wouldn't you include a module for disassembling PC executables on a PC application [01:20] yeah, the 32-bit version is not really ida 7, so this is unhelpful [01:23] pc.dll is in procs [01:23] in the 64-bit version [01:23] which helpfully comes with a 32-bit installer :) [01:24] GitHub11 (~GitHub11@192.30.252.41) joined #scummvm. [01:24] [scummvm] dafioram opened pull request #1020: SCI: Shivers1: Fix bad play call in room 23090 (master...shivers_sound-fix) https://git.io/v55VQ [01:24] GitHub11 (GitHub11@192.30.252.41) left #scummvm. [01:25] You're right, there is a pc.dll. What 32-bit installer do you mean? I just ran the installer I got from requesting a download link, which according to the release notes, installs the now full 64-bit app [01:25] yeah, but the installer for the 64-bit one is a 32-bit installer :) [01:26] Just got a copy of Starship Titanic .. turns out it is the Mac version [01:26] so i could at least look at what files are there or not, although i can't run it until i build a 64-bit VM [01:26] Oh, gotcha. :). So it really doesn't answer the question. [01:26] tsoliman: d'oh! [01:26] The jewel case cover didn't say!! [01:26] the CD itself says so though [01:26] or maybe, hurrah, open a bug for dreammaster ; [01:26] ;) [01:26] $1 :) [01:26] Really? Pity. :P How different is it? [01:27] the only computer with a CD is the windows PC and so it just "didn't read" for a bit and I was like "but the CD isn't scratched!!" [01:29] Well, it might prove useful someday to someone else wanting to flesh out support for all the variations [01:29] yep :) [01:30] I am dumping it now so I can actually open it on my mac [01:44] Lightkey (~Darklock@p200300764C71F83022CF30FFFE083718.dip0.t-ipconnect.de) left irc: Ping timeout: 255 seconds [01:50] ignalina (~pettersjo@h-238-36.A639.priv.bahnhof.se) joined #scummvm. [01:56] Lightkey (~Darklock@p200300764C71F87522CF30FFFE083718.dip0.t-ipconnect.de) joined #scummvm. [02:04] Nick change: Stormkeeper -> Storm-AFK [02:26] dreammaster: since i use bindiff and idados anyway im not in a huge rush to make a new VM right now :\ [02:27] the ida 7 upgrade seems really geared more toward analysis of modern software [02:36] True. Worst case, I just simply keep using 6.95 for now. Though it seems a bit of a wast having renewed for the year if they're no longer going to support the PC [02:38] Well, I'll have to check on the HwzeY forums and see if there's anything about it. Once I get access again.. My account got temporarily locked (something to do with respecifying what my license key number was) [02:43] s/hWZEY/Hexray/ [02:44] theres nothing about it there [02:44] Heh. Maybe us DOS game reversers are in a minority, then. Or everyone's just waiting till the weekend to install the update [02:45] hopefully someone with an appropriate environment can verify for you if there is a bug or not :) [02:49] Hopefully so. Let's see what happens [03:04] ignalina (~pettersjo@h-238-36.A639.priv.bahnhof.se) left irc: Quit: ignalina [03:10] dafioram (~dafioram@172.56.2.28) left irc: Quit: Leaving [03:16] dreammaster (~dreammast@c-73-149-116-247.hsd1.vt.comcast.net) left irc: [03:32] |Cable| (~cable@33.138.117.91.dynamic.reverse-mundo-r.com) left irc: Ping timeout: 246 seconds [03:46] |Cable| (~cable@33.138.117.91.dynamic.reverse-mundo-r.com) joined #scummvm. [04:05] GitHub84 (~GitHub84@192.30.252.35) joined #scummvm. [04:05] [scummvm] csnover pushed 1 new commit to master: https://git.io/v556H [04:05] scummvm/master 9203bdc Colin Snover: SDL: Remove USE_RGB_COLOR #ifdefs from detectSupportedFormats... [04:05] GitHub84 (GitHub84@192.30.252.35) left #scummvm. [04:05] GitHub196 (~GitHub196@192.30.252.40) joined #scummvm. [04:05] [scummvm] criezy pushed 1 new commit to master: https://git.io/v5567 [04:05] scummvm/master 45cadfd Thierry Crozat: I18N: Update translations templates [04:05] GitHub196 (GitHub196@192.30.252.40) left #scummvm. [04:20] user10 (~Thunderbi@leoseb.ujf-grenoble.fr) joined #scummvm. [04:21] Paaris (paaris@soju.fi) left irc: Ping timeout: 264 seconds [04:21] wjp (~wjp@hmm.wantstofly.org) left irc: Ping timeout: 264 seconds [04:22] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) left irc: Ping timeout: 264 seconds [04:22] Nick change: user10 -> user9 [04:27] wjp (~wjp@hmm.wantstofly.org) joined #scummvm. [05:04] Paaris (paaris@soju.fi) joined #scummvm. [05:21] GitHub140 (~GitHub140@192.30.252.40) joined #scummvm. [05:21] [scummvm] csnover pushed 1 new commit to master: https://git.io/v55X8 [05:21] scummvm/master 817c9e7 David Fioramonti: SCI32: Fix bad play call in Shivers room 23090... [05:21] GitHub140 (GitHub140@192.30.252.40) left #scummvm. [05:22] GitHub32 (~GitHub32@192.30.252.35) joined #scummvm. [05:22] [scummvm] csnover closed pull request #1020: SCI: Shivers1: Fix bad play call in room 23090 (master...shivers_sound-fix) https://git.io/v55VQ [05:22] GitHub32 (GitHub32@192.30.252.35) left #scummvm. [05:36] Littleboy (~littleboy@c-73-4-50-241.hsd1.ma.comcast.net) left irc: Quit: Ętre dans le vent, une ambition de feuille morte. [05:42] Begasus (~begasus@ptr-4p6jpim5z0cj75q8nz3.18120a2.ip6.access.telenet.be) joined #scummvm. [05:53] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) joined #scummvm. [06:19] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) left irc: Ping timeout: 240 seconds [06:20] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) joined #scummvm. [06:30] t0by (~t0by@unaffiliated/t0by) joined #scummvm. [06:30] #scummvm: mode change '+o t0by' by ChanServ!ChanServ@services. [06:36] jamm (~jam@unaffiliated/jamm) left irc: Read error: Connection reset by peer [06:48] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) left irc: Quit: Vision[0.10.1]: i've been blurred! [06:49] Begasus (~begasus@ptr-4p6jpim5z0cj75q8nz3.18120a2.ip6.access.telenet.be) left irc: Quit: Ex-Chat [07:18] Begasus (~begasus@ptr-4p6jpiop8ivrqz5gtua.18120a2.ip6.access.telenet.be) joined #scummvm. [07:18] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) joined #scummvm. [08:00] waltervn (~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl) joined #scummvm. [08:00] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [08:14] kurtwr (~kurtwr@c-73-116-30-72.hsd1.ca.comcast.net) left irc: Ping timeout: 246 seconds [08:15] kurtwr (~kurtwr@c-73-116-30-72.hsd1.ca.comcast.net) joined #scummvm. [08:31] LittleToonCat (~littlecat@47.54.148.237) left irc: Remote host closed the connection [08:36] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [08:36] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [08:51] Begasus (~begasus@ptr-4p6jpiop8ivrqz5gtua.18120a2.ip6.access.telenet.be) left irc: Ping timeout: 255 seconds [09:03] Begasus (~begasus@ptr-4p6jpiop8ivrqz5gtua.18120a2.ip6.access.telenet.be) joined #scummvm. [09:19] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) joined #scummvm. [09:26] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) left irc: Quit: Vision[0.10.1]: i've been blurred! [09:44] frankyboy_ (~franky@ppp109-252-73-38.pppoe.spdop.ru) joined #scummvm. [09:58] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) joined #scummvm. [10:52] ignalina (~pettersjo@h-238-36.A639.priv.bahnhof.se) joined #scummvm. [10:57] <_sev> mamma mia [10:57] <_sev> my ISP sent me a letter [10:58] <_sev> that from October they will be changing my speed [10:58] <_sev> ... [10:58] rootfather (~rootfathe@unaffiliated/rootfather) joined #scummvm. [10:58] #scummvm: mode change '+o rootfather' by ChanServ!ChanServ@services. [10:58] <_sev> from 150Mbit to 200Mbit, free of charge. Sigh [11:16] free of charge o_O [11:16] ajax16384 (~User@109.60.130.33) joined #scummvm. [11:16] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [11:17] vv222 (~vv221@dotslashplay.it) left irc: Ping timeout: 246 seconds [11:22] I just upgraded my ISP connection from 16Mbit to ~65Mbit. [11:22] but not free of charge ;D [11:22] btw - hello folks, I'm happy to be back on track :) [11:24] DrMcCoy (~drmccoy@xoreos/drmccoy) left irc: Ping timeout: 248 seconds [11:26] GitHub149 (~GitHub149@192.30.252.42) joined #scummvm. [11:26] [scummvm] m-kiewitz pushed 1 new commit to master: https://git.io/v55b3 [11:26] scummvm/master 5c901af Martin Kiewitz: SCI: LB2-Dual mode: Change "DUAL" button to "BOTH"... [11:26] GitHub149 (GitHub149@192.30.252.42) left #scummvm. [11:26] PQ4 coming next [11:31] vv222 (~vv221@dotslashplay.it) joined #scummvm. [11:33] DrMcCoy (~drmccoy@xoreos/drmccoy) joined #scummvm. [11:33] #scummvm: mode change '+o DrMcCoy' by ChanServ!ChanServ@services. [11:42] rootfather (~rootfathe@unaffiliated/rootfather) left irc: [11:42] DrMcCoy (~drmccoy@xoreos/drmccoy) left irc: Ping timeout: 264 seconds [11:50] ignalina (~pettersjo@h-238-36.A639.priv.bahnhof.se) left irc: Quit: ignalina [11:54] ignalina (~pettersjo@h-238-36.A639.priv.bahnhof.se) joined #scummvm. [12:00] dafioram (~dafioram@pool-71-121-237-223.bltmmd.fios.verizon.net) joined #scummvm. [12:20] vv222 (~vv221@dotslashplay.it) left irc: Ping timeout: 260 seconds [12:23] Begasus (~begasus@ptr-4p6jpiop8ivrqz5gtua.18120a2.ip6.access.telenet.be) left irc: Ping timeout: 264 seconds [12:33] vv222 (~vv221@210.28.92.79.rev.sfr.net) joined #scummvm. [12:35] Begasus (~begasus@ptr-4p6jpiop8ivrqz5gtua.18120a2.ip6.access.telenet.be) joined #scummvm. [12:36] ignalina (~pettersjo@h-238-36.A639.priv.bahnhof.se) left irc: Quit: ignalina [12:42] vv222 (~vv221@210.28.92.79.rev.sfr.net) left irc: Ping timeout: 255 seconds [13:10] vv222 (~vv221@dotslashplay.it) joined #scummvm. [13:37] dreammaster (~dreammast@c-73-149-116-247.hsd1.ma.comcast.net) joined #scummvm. [13:37] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [13:39] GitHub150 (~GitHub150@192.30.252.35) joined #scummvm. [13:39] [scummvm] dreammaster pushed 1 new commit to master: https://git.io/v55jX [13:39] scummvm/master bce9ba0 Paul Gilbert: TITANIC: Standardize audio rate constants [13:39] GitHub150 (GitHub150@192.30.252.35) left #scummvm. [13:43] vv221 (~vv221@210.28.92.79.rev.sfr.net) joined #scummvm. [13:45] vv222 (~vv221@dotslashplay.it) left irc: Ping timeout: 252 seconds [13:47] vv222 (~vv221@dotslashplay.it) joined #scummvm. [13:50] vv221 (~vv221@210.28.92.79.rev.sfr.net) left irc: Ping timeout: 240 seconds [14:14] Littleboy (~littleboy@c-73-4-50-241.hsd1.ma.comcast.net) joined #scummvm. [14:14] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [14:15] Dubberino (~Dubbins@gateway/vpn/privateinternetaccess/dubbins) left irc: Remote host closed the connection [14:16] Dubberino (~Dubbins@gateway/vpn/privateinternetaccess/dubbins) joined #scummvm. [14:17] vv222 (~vv221@dotslashplay.it) left irc: Ping timeout: 246 seconds [14:43] dafioram (~dafioram@pool-71-121-237-223.bltmmd.fios.verizon.net) left irc: Quit: Leaving [14:45] ny00123 (~ny00123@141.226.161.161) joined #scummvm. [14:46] vv222 (~vv221@210.28.92.79.rev.sfr.net) joined #scummvm. [14:47] DrMcCoy (~drmccoy@xoreos/drmccoy) joined #scummvm. [14:47] #scummvm: mode change '+o DrMcCoy' by ChanServ!ChanServ@services. [14:48] vv221 (~vv221@dotslashplay.it) joined #scummvm. [14:51] vv222 (~vv221@210.28.92.79.rev.sfr.net) left irc: Ping timeout: 260 seconds [14:52] Nick change: vv221 -> vv222 [14:56] ajax16384 (~User@109.60.130.33) left irc: Read error: Connection reset by peer [15:23] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) left irc: Ping timeout: 255 seconds [15:26] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) joined #scummvm. [15:48] Nick change: Storm-AFK -> Stormkpr [15:57] dreammaster (~dreammast@c-73-149-116-247.hsd1.ma.comcast.net) left irc: [15:58] m_kiewitz: hi. the cleanest way to enhance the view in PQ4 would probably be to patch the resource in ResourceManager, using a currently non-existing mechanism. this wouldnt be very hard to write, i can look into doing that. its not needed super often but phantasmagoria has a resource id rather change that way too (right now its got a hack in the CelObjView constructor which i dont like). [15:58] Begasus (~begasus@ptr-4p6jpiop8ivrqz5gtua.18120a2.ip6.access.telenet.be) left irc: Ping timeout: 264 seconds [15:58] sure [15:58] i just need to get it in there [15:58] currently coming up with a patch [15:59] i verified the game, there is a tiny bit of special code, for example the fridge at the end, but it seems there shouldn't be issues [15:59] we probably will have to remove resets to global 5Ah on init and on restart [15:59] then it should work all the time [15:59] (well and my menu patch) [16:00] oh any knowledge about what mainLoop and maskLoop selectors are for? [16:00] it almost seems to me the maskLoop is used when mainLoop is invalid [16:01] it seems i can change the code to only set mainView/mainLoop/mainCel for it to work [16:01] let me look here& [16:05] looks like the dithered mask that gets rendered on top of an action icon when it is unable to be interacted with [16:06] and when is it set? [16:06] its really weird that sierra sets both selector types all the time [16:07] and it seems they are even not fully sync'd [16:07] the masked one is always at loop 0, cel 1 [16:09] maybe that new graphic of mine should get put in there are new loop [16:09] so 10987, loop 1 [16:10] the mask is used when signal flag 4 is set [16:10] and it only applies to control panel stuff [16:10] Begasus (~begasus@ptr-4p6jpiop8ivrqz5gtua.18120a2.ip6.access.telenet.be) joined #scummvm. [16:10] only things extending from PQIconItem [16:11] hmm weird that they set it (and well set it not completely) [16:12] oops, sorry. things extending from IconI. [16:12] but again this is just control panel icons, icon bar icons, inventory item icons. [16:24] _sev_ (~sev@scummvm/undead/sev) joined #scummvm. [16:24] #scummvm: mode change '+o _sev_' by ChanServ!ChanServ@services. [16:25] _sev (~sev@scummvm/undead/sev) left irc: Ping timeout: 240 seconds [16:26] Nick change: Stormkpr -> Stormkeeper [16:45] Begasus (~begasus@ptr-4p6jpiop8ivrqz5gtua.18120a2.ip6.access.telenet.be) left irc: Ping timeout: 240 seconds [16:47] LittleToonCat (~littlecat@47.54.148.237) joined #scummvm. [16:56] Begasus (~begasus@ptr-4p6jpiop8ivrqz5gtua.18120a2.ip6.access.telenet.be) joined #scummvm. [17:58] GitHub148 (~GitHub148@192.30.252.35) joined #scummvm. [17:58] [scummvm] m-kiewitz pushed 1 new commit to master: https://git.io/v5dcp [17:58] scummvm/master bbbbfb6 Martin Kiewitz: SCI32: Add script patch for PQ4CD for dual mode (text+speech)... [17:58] GitHub148 (GitHub148@192.30.252.35) left #scummvm. [17:58] someone will have to play through this once more to test out dual mode :p [18:06] dreammaster (~dreammast@c-73-149-116-247.hsd1.vt.comcast.net) joined #scummvm. [18:06] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [18:09] GitHub114 (~GitHub114@192.30.252.45) joined #scummvm. [18:09] [scummvm] dreammaster pushed 1 new commit to master: https://git.io/v5dC3 [18:09] scummvm/master 09931ae Paul Gilbert: TITANIC: Fixed FixedQueue compaction when queue has been emptied [18:09] GitHub114 (GitHub114@192.30.252.45) left #scummvm. [18:20] l0ftyWhizZ (8b3b1cdc@gateway/web/freenode/ip.139.59.28.220) joined #scummvm. [18:20] Hey guys! A new dev here :) [18:21] hi l0ftyWhizZ. [18:22] l0ftyWhizZ_ (9d310837@gateway/web/freenode/ip.157.49.8.55) joined #scummvm. [18:22] Me being a retro games lover was amazed by the idea behind ScummVM, and with my previous experience in game development, would love to contribute to this. [18:23] G'day :) [18:23] Can I get a place from where I can start? Thanks :D [18:23] l0ftyWhizZ_: do you have some particular interest in some game? [18:23] Well, what kind of thing tickles your fancy? Working on a specific game you're interested in? Working on a particular port/system support? Documentation? Even parts of the core system could use some TLC from an interested developer [18:24] oh. dreammaster is more prepared than i am to ask such questions, it seems :) [18:24] Oh, no, feel free to chime in. I've really only got experience with the game engine development side.. we'll have to rely on others if one of the other areas peaks your interest [18:25] l0ftyWhizZ (8b3b1cdc@gateway/web/freenode/ip.139.59.28.220) left irc: Ping timeout: 260 seconds [18:25] Like currently I am developing a Third Person multiplayer shooter in Unity, so I am really interested in actually building new games. [18:26] New games as in reimplementing an new game engine for an existing game? Or building an entirely original game from scratch? [18:27] Actually both. I have had my share of building an engine in LWJGL, and the latter as well [18:28] Well, for existing games, it's generally a matter of settling on a specific adventure (or RPG now) that you're interested in and starting work on it. The following is a useful list of engines that are or have been worked on to avoid any duplication of effort: http://wiki.scummvm.org/index.php/Engines [18:28] The following link is also useful if you're only just getting started on reverse engineering games: http://wiki.scummvm.org/index.php/HOWTO-Reverse_Engineering [18:29] klusark (~klusark@S01066c3b6b1953d0.vc.shawcable.net) left irc: Quit: quit [18:29] As for creating entirely original games, it may be simpler just to avoid all the complexities of writing code and use an existing engine. Like Wintermute, AGI, or SCI. There are editors out there for all of them. For that matter, there's also AGS, which is popular, but ScummVM doesn't currently have an engine for it [18:30] Yeah that's true. I wil surely check these links out. Thanks a lot :D [18:31] No problem. And if you decide to work on reverse engineering and implementing a game, feel free to drop by any time for a chat and advise [18:32] Surely I will. [18:39] klusark (~klusark@S01066c3b6b1953d0.vc.shawcable.net) joined #scummvm. [19:00] waltervn (~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl) left irc: Ping timeout: 240 seconds [19:19] l0ftyWhizZ (~l0ftyWhiz@157.49.8.55) joined #scummvm. [19:21] l0ftyWhizZ_ (9d310837@gateway/web/freenode/ip.157.49.8.55) left irc: Ping timeout: 260 seconds [19:23] GitHub7 (~GitHub7@192.30.252.45) joined #scummvm. [19:23] [scummvm] dreammaster pushed 1 new commit to master: https://git.io/v5d8c [19:23] scummvm/master 3e5515c Paul Gilbert: TITANIC: Improve audio buffer critial section handling [19:23] GitHub7 (GitHub7@192.30.252.45) left #scummvm. [19:25] Littleboy (~littleboy@c-73-4-50-241.hsd1.ma.comcast.net) left irc: Read error: Connection reset by peer [19:26] girafe (~girafe@LFbn-1-8040-185.w90-112.abo.wanadoo.fr) joined #scummvm. [19:26] Littleboy (~littleboy@c-73-4-50-241.hsd1.ma.comcast.net) joined #scummvm. [19:26] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [20:08] Littleboy (~littleboy@c-73-4-50-241.hsd1.ma.comcast.net) left irc: Ping timeout: 248 seconds [20:27] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) left irc: Ping timeout: 240 seconds [20:29] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) joined #scummvm. [20:29] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) left irc: Remote host closed the connection [20:49] m_kiewitz: do you still have a gk1 save game at the day 10 dress-up room that you could send me? [20:49] I had, but that saved game don't work anymore [20:50] i can make it work. could you send it to me? [20:50] hmm, should probably on our FTP [20:50] *be [20:51] yes, my saves are on the FTP [20:57] Begasus (~begasus@ptr-4p6jpiop8ivrqz5gtua.18120a2.ip6.access.telenet.be) left irc: Quit: Ex-Chat [20:59] AndChat|594561 (~l0ftyWhiz@14.139.155.24) joined #scummvm. [20:59] Nick change: Stormkeeper -> Storm-AFK [20:59] l0ftyWhizZ (~l0ftyWhiz@157.49.8.55) left irc: Read error: Connection reset by peer [21:02] i lied, i didnt realise they were quite so old. [21:10] lol [21:10] waltervn (~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl) joined #scummvm. [21:11] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [21:18] l0ftyWhizZ (0e8b9b18@gateway/web/freenode/ip.14.139.155.24) joined #scummvm. [21:21] girafe (~girafe@LFbn-1-8040-185.w90-112.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [21:34] GitHub100 (~GitHub100@192.30.252.41) joined #scummvm. [21:34] [scummvm] csnover pushed 18 new commits to master: https://git.io/v5dzT [21:34] scummvm/master 60460cc Colin Snover: GIT: Ignore all root Xcode project files... [21:34] scummvm/master 96d4bb6 Colin Snover: SCI32: Clean-up pass on GK1 script patches... [21:34] scummvm/master bbcee7e Colin Snover: SCI32: Clean-up pass on GK2 script patches... [21:34] GitHub100 (GitHub100@192.30.252.41) left #scummvm. [21:36] t0by (~t0by@unaffiliated/t0by) left irc: Remote host closed the connection [21:41] Littleboy (~littleboy@c-73-4-50-241.hsd1.ma.comcast.net) joined #scummvm. [21:41] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [21:42] snover: why do you even remove my "Responsible method" and especially the bug numbers? [21:44] The method name is in the comment already and the ticket number is in the git log already. [21:45] And the script number is in the patch table already. [21:45] The point was that you don't have to search around in git [21:46] we have bug numbers all over the place and it's really nice to have [21:46] you can of course remove all bug numbers, but I think that would really suck [21:49] When is the last time you used a ticket number in a script patch comment to look up a ticket ? I can't think of a time in the past when I have ever actually done that, and when I look things up I usually have to look at the git (log or blame or both) regardless since I don't know what else might have changed in the interim [21:50] it would also be really nice if you could ask me before doing such massive changes to my patches. [21:50] Does it hurt when the bug number is there? Do we have a line limit per C++ file? [21:51] I used it a few times. And I also replaced almost all bug numbers, when we changed from sourceforge to the ScummVM bug tracker. [21:52] oh right, what would you do in that case, when this happens once more? When we use another tracker with new numbers? Then the git comments will be outdated [21:52] I even added tons of such information to older patches, where this information was not provided [21:53] You also removed room information [21:53] script number, which get patched, does not need to be the room number [21:53] This information is really useful, when a patch causes issues and you have to fix it months or years after creating it [21:54] I had to do exactly this with at least one of my kq6 patches, because it caused regressions [21:54] And then you have to look at the change history in git anyway to figure out the regression don't you? [21:55] ??? [21:55] Incidentally all the old SF ticket numbers are in the new tracker and can be searched for [21:55] the issue was caused by the patch [21:55] i fixed the patch itself and I figured out that it was the patch by even just seeing the footage [21:56] it was obvious [21:56] sourceforge had effectively 2 numbers even [21:57] they changed numbering at some point and the older numbers stopped working at some point [21:57] GitHub149 (~GitHub149@192.30.252.42) joined #scummvm. [21:57] [scummvm] dreammaster pushed 1 new commit to master: https://git.io/v5dgt [21:57] scummvm/master 7a1d359 Paul Gilbert: TITANIC: Fix music playback in music room [21:57] GitHub149 (GitHub149@192.30.252.42) left #scummvm. [21:57] The old numbers are there too [21:57] it still sucks [21:57] before you had to have simply a copy of the source and the bug tracker data [21:57] now you need git [21:57] Yay. All outstanding bugs fixed. So now it's just waiting for your cursor fixes, snover :) [21:58] I mean does it hurt that much that a bug number is in there? [21:58] dreammaster: awesome, [21:58] I really don't see the point in removing it [21:58] ! [21:58] and why don't you remove it simply everywhere [21:58] right now it's a 100% mess [21:58] It gives a false sense of security that the comment is accurate to the history of the code [21:59] dafioram (~dafioram@pool-71-121-237-223.bltmmd.fios.verizon.net) joined #scummvm. [22:01] After so long either the code has had no problem so there's no need for a ticket reference , or the code has changed again and the comment doesn't reflect the true history with subsequent ticket numbers and edirs [22:01] Edits* [22:01] there is of course a need for a ticket reference [22:02] when you want to simply look into what exactly happened, then the ticket data is quite valuable [22:02] ignalina (~pettersjo@h-238-36.A639.priv.bahnhof.se) joined #scummvm. [22:02] that's why we put it also into the workarounds table [22:02] I mean why even leave the comments in there? [22:03] you can always just go to git, then figure out the ticket number hopefully and then read it up on the bug tracker [22:03] we can just remove the comments too, including the ones for all the workarounds [22:03] that makes no sense, but following that line of thought we would have to do that [22:04] I don't know why leave those either. In the past maybe it makes sense since the VCS was not distributed so you couldn't easily always get the full code history, but now you are more likely to have the git history than the bug tracker [22:04] But I wasn't looking at that code [22:05] Was the last kq6 issue the broken death text box with text+speech? [22:05] Is that the one you are thinking of? [22:05] there was an issue when falling down [22:05] Falling down and the text box would half display? [22:05] probably [22:06] OK, so I actually bisected the regression for you from git [22:08] frankyboy_ (~franky@ppp109-252-73-38.pppoe.spdop.ru) left irc: Remote host closed the connection [22:09] In any case, I am not ever making any such changes to sci16 specifically because I don't worry you about that at all [22:12] you also removed tons of internal information on some of the patches. Sometimes it's a nightmare to figure out how it works internally and having that information available *somewhere* is quite nice. Sure, when you never have to touch it, it won't matter. [22:17] ny00123 (~ny00123@141.226.161.161) left irc: Quit: Leaving [22:17] for example why did you remove this too? [22:17] / Strangely this "talker" data seems to be quite broken. [22:17] / For example chapter 2 starts with a cutscene. [22:17] / Troll king: "Welcome, most beautiful of princesses!" - talker 6 [22:17] / Which is followed by the princess going [22:17] / "Hmm?" - which is set to talker 99, normally the princess is talker 7. [22:17] Was kq7 subtitles fully tested out? [22:18] / Talker 99 is seen as unknown and thus treated as "narrator", which makes [22:18] / the scripts put the text at the top of the game screen and even use a [22:18] / different font. [22:18] If anyone has to fix some issue, that additional information was nice to have as an example for that bogus data [22:18] but now it's gone. [22:18] l0ftyWhizZ (0e8b9b18@gateway/web/freenode/ip.14.139.155.24) left irc: Ping timeout: 260 seconds [22:18] I really don't see a point in removing such information. It's source code anyway, it's not meant for end users [22:19] l0ftyWhizZ (~l0ftyWhiz@157.49.11.69) joined #scummvm. [22:19] Now it basically says "well, there is bogus data somewhere" and that's it. Or "well at the start of chapter 2 ... somewhere" [22:20] That of course won't matter unless there is an issue and someone has to look into it in 4 years or so. And then that person can start from scratch. [22:20] I must have fixed that kq6 issue probably some years after creating the original patch. [22:22] AndChat|594561 (~l0ftyWhiz@14.139.155.24) left irc: Ping timeout: 246 seconds [22:29] erdic (~erdic@unaffiliated/motley) left irc: Remote host closed the connection [22:32] waltervn (~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl) left irc: Ping timeout: 240 seconds [22:33] Littleboy (~littleboy@c-73-4-50-241.hsd1.ma.comcast.net) left irc: Read error: Connection reset by peer [22:33] Littleboy (~littleboy@c-73-4-50-241.hsd1.ma.comcast.net) joined #scummvm. [22:33] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [22:40] dreammaster (~dreammast@c-73-149-116-247.hsd1.vt.comcast.net) left irc: [22:45] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) left irc: Quit: ERR_SHUTDOWN [22:50] m_kiewitz: those are literally the first two lines at the start of chapter 2. and, i have a lot of confidence in your ability to write script patches that are reliable and work well. and, this information is not gone, if these changes are super confusing to someone (which was the opposite of what i was trying to do) all the old information is one `git log` away. [22:52] if most of the patches that i wrote have some problem and the only way to know of the problem was for me to have written all this information for all of those patches then we are going to be in big trouble. but so far everything has been fine so i dont have a concern, but if you notice in the future that ive fucked something up horribly please let me know so i can learn from it. [23:15] AndChat|594561 (~l0ftyWhiz@14.139.155.24) joined #scummvm. [23:15] l0ftyWhizZ (~l0ftyWhiz@157.49.11.69) left irc: Read error: Connection reset by peer [23:19] balrog (~balrog@unaffiliated/balrog) left irc: Quit: Bye [23:23] balrog (~balrog@unaffiliated/balrog) joined #scummvm. [23:24] l0ftyWhizZ (~l0ftyWhiz@157.49.8.169) joined #scummvm. [23:25] AndChat-594561 (~l0ftyWhiz@103.231.132.5) joined #scummvm. [23:25] l0ftyWhizZ (~l0ftyWhiz@157.49.8.169) left irc: Read error: Connection reset by peer [23:29] AndChat|594561 (~l0ftyWhiz@14.139.155.24) left irc: Ping timeout: 264 seconds [23:29] balrog (~balrog@unaffiliated/balrog) left irc: Ping timeout: 246 seconds [23:32] kurtwr2 (~kurtwr@c-73-116-30-72.hsd1.ca.comcast.net) joined #scummvm. [23:33] balrog (~balrog@unaffiliated/balrog) joined #scummvm. [23:33] kurtwr (~kurtwr@c-73-116-30-72.hsd1.ca.comcast.net) left irc: Ping timeout: 248 seconds [23:43] l0ftyWhizZ (~l0ftyWhiz@157.49.8.184) joined #scummvm. [23:44] AndChat|594561 (~l0ftyWhiz@157.49.8.184) joined #scummvm. [23:45] l0ftyWhizZ (~l0ftyWhiz@157.49.8.184) left irc: Read error: Connection reset by peer [23:45] AndChat|594561 (~l0ftyWhiz@157.49.8.184) left irc: Read error: Connection reset by peer [23:45] l0ftyWhizZ (~l0ftyWhiz@14.139.155.24) joined #scummvm. [23:47] AndChat-594561 (~l0ftyWhiz@103.231.132.5) left irc: Ping timeout: 264 seconds [23:49] dreammaster (~dreammast@c-73-149-116-247.hsd1.ma.comcast.net) joined #scummvm. [23:49] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [23:50] l0ftyWhizZ (~l0ftyWhiz@14.139.155.24) left irc: Ping timeout: 264 seconds [23:51] GitHub33 (~GitHub33@192.30.252.40) joined #scummvm. [23:51] [scummvm] m-kiewitz pushed 1 new commit to master: https://git.io/v5dwP [23:51] scummvm/master 1d018d6 Martin Kiewitz: SCI32: Clean-up pass on GK1,GK2,KQ7,PQ4,QfG4,Torin script patches... [23:51] GitHub33 (GitHub33@192.30.252.40) left #scummvm. [23:51] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray. [23:51] Littleboy (~littleboy@c-73-4-50-241.hsd1.ma.comcast.net) left irc: Quit: Ętre dans le vent, une ambition de feuille morte. [00:00] --- Sun Sep 17 2017