ScummVM IRC Log - 25 Feb 2017

[Back to Index]

[00:06] --> Strangerke_ joined #scummvm.
[00:09] <-- Strangerke left irc: Ping timeout: 268 seconds
[00:09] Nick change: Strangerke_ -> Strangerke
[00:14] <-- waltervn left irc: Quit: Leaving
[00:17] <-- WooShell left irc: Quit: If you understand or if you don't, if you believe or if you doubt - There's a universal justice, and the eyes of truth are always watching you.
[00:24] --> omer_mor joined #scummvm.
[00:25] --> lavosspawn joined #scummvm.
[00:36] --> Littleboy joined #scummvm.
[00:36] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[00:51] <-- Farmboy0 left irc: Remote host closed the connection
[01:04] --> gk_-1wm_- joined #scummvm.
[01:04] gk_-1wm_- (su@50.118.213.31) left #scummvm.
[01:09] --> dreammaster joined #scummvm.
[01:09] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[01:14] <m-kiewitz> oh oh oh
[01:22] <m-kiewitz> snover: there is currently an active ebay paypal discount code
[01:22] <m-kiewitz> only valid for another 40 minutes sadly
[01:22] <m-kiewitz> i didn't see it earlier
[01:22] <m-kiewitz> $10 off $50 purchases
[01:22] <snover> thanks, i still dont buy physical items though :)
[01:23] <m-kiewitz> well it's valid for anything
[01:30] <m-kiewitz> oh nice gold rush (Apple IIgs) for $85
[01:30] <m-kiewitz> http://www.ebay.com/itm/Gold-Rush-for-Apple-IIGS-by-Sierra-On-Line-1988-computer-adventure-game-/361515464190
[01:33] <m-kiewitz> if only waltervn would be here :(
[01:51] <snover> man. git is so nice sometimes. i mysteriously broke walking in lsl7, but i did so much rebasing today on this branch i had no clue what might have happened. a quick `git diff working@{one.day.ago}..working engines/sci/` and i found the answer.
[01:54] <snover> all hail the reflog.
[02:27] --> gk_-1wm joined #scummvm.
[02:27] gk_-1wm (su@209.73.151.42) left #scummvm.
[02:39] <rsn8887> snover: yes. I managed to do it. Since it might be a while until the whole Vita port branch is merged, do you want me to make a new PR for my shader menu code?
[02:40] <-- Dominus left irc: Ping timeout: 240 seconds
[02:40] <snover> its up to you.
[02:40] <rsn8887> snover: It adds a new tab for shader selection. Right now this is only used by the (yet to be merged) Vita backend. But my code is simply adding getSupportedShaders, getShader and setShader functions to OSystem and GraphicsManager (and ModularBackend)
[02:41] <rsn8887> snover: The tab is hidden unless the backend has the new feature kFeatureShaders.
[02:41] <rsn8887> It will allow users to select shaders in combination with scalers for example for scanline overlays etc.
[02:42] <rsn8887> There should be zero impact on current ports, but future possibility for many backends to implement shaders.
[02:42] --> Dominus joined #scummvm.
[02:42] <-- Dominus left irc: Changing host
[02:42] --> Dominus joined #scummvm.
[02:42] <snover> ok. i dont think i know enough to give any useful feedback.
[02:42] <rsn8887> I guess I will simply create the PR and if someone is interested they can merge it.
[02:44] --> Vampire0_ joined #scummvm.
[02:46] <-- SylvainTV left irc: Read error: Connection reset by peer
[02:46] <-- TMM left irc: Ping timeout: 240 seconds
[02:47] <-- Vampire0 left irc: Ping timeout: 240 seconds
[02:47] <-- m-kiewitz left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray.
[02:48] --> TMM joined #scummvm.
[02:48] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[02:52] --> GitHub120 joined #scummvm.
[02:52] <GitHub120> [scummvm] rsn8887 opened pull request #910: SDL: added shader menu (hidden if no shaders) (master...upstream) https://git.io/vyTfX
[02:52] GitHub120 (GitHub120@192.30.252.41) left #scummvm.
[03:07] <Lightkey> The Dagger of Amon Ra continues on twitch.tv/gogcom now :-)
[03:10] <Lightkey> "what's Tex Murphy doing with that guy?"
[03:39] <Lightkey> "oh, there is actually collision in this game! he wants to go by, move, move!"
[03:40] <Lightkey> at least it continued when she got out of the way instead of hanging like in The Colonel's Bequest :-)
[03:41] --> GitHub50 joined #scummvm.
[03:41] <GitHub50> [scummvm] rsn8887 closed pull request #910: SDL: added shader menu (hidden if no shaders) (master...upstream) https://git.io/vyTfX
[03:41] GitHub50 (GitHub50@192.30.252.40) left #scummvm.
[03:42] <rsn8887> Nevermind, I will make that pull request only as part of the vita branch. I think it will create a nightmare to merge if I duplicate once within and once outside the vita branch
[04:30] --> GitHub132 joined #scummvm.
[04:30] <GitHub132> [scummvm] dreammaster pushed 2 new commits to master: https://git.io/vyTkO
[04:30] <GitHub132> scummvm/master 985f8a3 Paul Gilbert: TITANIC: Fixes for coordinates init in CStarPoints1
[04:30] <GitHub132> scummvm/master e107003 Paul Gilbert: TITANIC: Some preliminary cleanup of star control interfaces
[04:30] GitHub132 (GitHub132@192.30.252.34) left #scummvm.
[04:40] <-- dreammaster left irc:

[05:04] <-- lavosspawn left irc: Ping timeout: 255 seconds
[05:09] <-- snover left irc: Ping timeout: 255 seconds
[05:10] --> omer_mor_ joined #scummvm.
[05:10] --> _sev_ joined #scummvm.
[05:10] #scummvm: mode change '+o _sev_' by ChanServ!ChanServ@services.
[05:10] --> kurtwr2 joined #scummvm.
[05:11] --> user10 joined #scummvm.
[05:14] --> wjp_ joined #scummvm.
[05:15] --> erdic_ joined #scummvm.
[05:15] --> snover joined #scummvm.
[05:15] #scummvm: mode change '+o snover' by ChanServ!ChanServ@services.
[05:16] <-- tsoliman left irc: Ping timeout: 260 seconds
[05:16] <-- user9 left irc: Ping timeout: 260 seconds
[05:16] <-- Cheeseness left irc: Ping timeout: 260 seconds
[05:16] <-- aquadran left irc: Ping timeout: 260 seconds
[05:16] <-- TMM left irc: Ping timeout: 260 seconds
[05:16] <-- Vampire0_ left irc: Ping timeout: 260 seconds
[05:16] <-- _sev left irc: Ping timeout: 260 seconds
[05:16] <-- erdic left irc: Ping timeout: 260 seconds
[05:16] <-- Dominus left irc: Ping timeout: 240 seconds
[05:16] <-- omer_mor left irc: Ping timeout: 240 seconds
[05:16] <-- kurtwr left irc: Ping timeout: 240 seconds
[05:16] <-- wjp left irc: Ping timeout: 240 seconds
[05:16] <-- balrog left irc: Ping timeout: 240 seconds
[05:16] --> tsoliman_ joined #scummvm.
[05:16] Nick change: user10 -> user9
[05:16] Nick change: erdic_ -> erdic
[05:16] --> Dominus joined #scummvm.
[05:16] <-- Dominus left irc: Changing host
[05:16] --> Dominus joined #scummvm.
[05:17] --> Vampire0_ joined #scummvm.
[05:18] --> balrog joined #scummvm.
[05:18] --> TMM joined #scummvm.
[05:18] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[05:18] --> aquadran joined #scummvm.
[05:18] #scummvm: mode change '+o aquadran' by ChanServ!ChanServ@services.
[05:19] --> Deledrius_ joined #scummvm.
[05:23] <-- Deledrius__ left irc: Ping timeout: 240 seconds
[05:39] --> Deledrius__ joined #scummvm.
[05:41] <-- aquadran left irc: Ping timeout: 260 seconds
[05:41] --> aquadran joined #scummvm.
[05:41] #scummvm: mode change '+o aquadran' by ChanServ!ChanServ@services.
[05:42] <-- Deledrius_ left irc: Ping timeout: 240 seconds
[05:42] <-- Dominus left irc: Ping timeout: 240 seconds
[05:42] --> Dominus joined #scummvm.
[05:42] <-- Dominus left irc: Changing host
[05:42] --> Dominus joined #scummvm.
[05:42] --> Deledrius_ joined #scummvm.
[05:45] <-- Deledrius__ left irc: Ping timeout: 240 seconds
[06:01] --> Cheeseness joined #scummvm.
[06:11] --> exmensa_ joined #scummvm.
[06:14] <-- exmensa left irc: Ping timeout: 260 seconds
[06:27] --> Deledrius__ joined #scummvm.
[06:30] <-- Deledrius_ left irc: Ping timeout: 240 seconds
[06:52] --> Begasus joined #scummvm.
[08:02] <-- Lightkey left irc: Ping timeout: 240 seconds
[08:16] --> Lightkey joined #scummvm.
[08:25] --> waltervn joined #scummvm.
[08:25] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[08:25] <waltervn> morning
[08:26] --> vinayakvivek joined #scummvm.
[08:35] <-- LittleToonCat left irc: Remote host closed the connection
[08:49] --> ny00123 joined #scummvm.
[08:58] --> Begas_VBox joined #scummvm.
[09:10] <Begasus> morning
[09:10] Nick change: Vampire0_ -> Vampire0
[09:11] <-- Vampire0 left irc: Quit: Verlassend
[09:11] --> Vampire0 joined #scummvm.
[09:11] <-- Vampire0 left irc: Remote host closed the connection
[09:12] --> Vampire0_ joined #scummvm.
[09:12] Nick change: Vampire0_ -> Vampire0
[09:18] --> jamm joined #scummvm.
[09:42] <-- TMM left irc: Ping timeout: 240 seconds
[10:07] --> Deledrius_ joined #scummvm.
[10:11] <-- Deledrius__ left irc: Ping timeout: 240 seconds
[10:26] --> Strangerke_ joined #scummvm.
[10:28] <-- Strangerke left irc: Ping timeout: 255 seconds
[10:28] Nick change: Strangerke_ -> Strangerke
[10:45] --> Netmage joined #scummvm.
[10:50] <-- girafe left irc: Read error: Connection reset by peer
[11:02] --> Strangerke_ joined #scummvm.
[11:03] <-- Strangerke left irc: Ping timeout: 260 seconds
[11:03] Nick change: Strangerke_ -> Strangerke
[11:35] <-- Deledrius_ left irc: Read error: Network is unreachable
[11:36] --> Deledrius_ joined #scummvm.
[11:37] <-- jamm left irc: Read error: Connection reset by peer
[11:51] --> TMM joined #scummvm.
[11:51] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[12:01] --> WooShell joined #scummvm.
[12:27] Nick change: wjp_ -> wjp
[12:28] #scummvm: mode change '+o wjp' by ChanServ!ChanServ@services.
[12:46] <-- Netmage left irc: Quit: My MacBook has gone to sleep. ZZZzzz&
[12:55] <WooShell> good meowning =^.^=
[13:00] --> girafe joined #scummvm.
[13:07] --> lubomyr joined #scummvm.
[13:31] <-- eriktorbjorn left irc: Read error: Connection reset by peer
[13:36] --> eriktorbjorn joined #scummvm.
[13:36] #scummvm: mode change '+o eriktorbjorn' by ChanServ!ChanServ@services.
[13:38] <-- Cheeseness left irc: Quit: Leaving.
[13:43] --> Cheeseness joined #scummvm.
[13:53] --> Strangerke_ joined #scummvm.
[13:56] <-- Strangerke left irc: Ping timeout: 268 seconds
[13:56] Nick change: Strangerke_ -> Strangerke
[13:59] <-- ST1 left irc: Quit: Leaving.
[14:01] <-- Cheeseness left irc: Quit: Leaving.
[14:08] <-- lubomyr left irc: Ping timeout: 255 seconds
[14:10] --> Cheeseness joined #scummvm.
[14:14] --> ST joined #scummvm.
[14:14] #scummvm: mode change '+o ST' by ChanServ!ChanServ@services.
[14:31] <-- Cheeseness left irc: Quit: Leaving.
[14:33] <-- eriktorbjorn left irc: Ping timeout: 240 seconds
[14:34] --> eriktorbjorn joined #scummvm.
[15:12] --> Netmage joined #scummvm.
[15:21] --> Farmboy0 joined #scummvm.
[15:21] <-- Farmboy0 left irc: Changing host
[15:21] --> Farmboy0 joined #scummvm.
[15:29] --> Styrbjorn joined #scummvm.
[15:36] <-- Deledrius_ left irc: Read error: Network is unreachable
[15:37] --> Deledrius_ joined #scummvm.
[15:46] --> Strangerke_ joined #scummvm.
[15:47] --> m_kiewitz joined #scummvm.
[15:47] <-- m_kiewitz left irc: Changing host
[15:47] --> m_kiewitz joined #scummvm.
[15:47] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services.
[15:48] <-- Strangerke left irc: Ping timeout: 260 seconds
[15:48] Nick change: Strangerke_ -> Strangerke
[15:53] --> Cheeseness joined #scummvm.
[16:13] --> Deledrius__ joined #scummvm.
[16:16] <-- Deledrius_ left irc: Ping timeout: 240 seconds
[16:18] --> ajax16384 joined #scummvm.
[16:18] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[16:27] --> LittleToonCat joined #scummvm.
[16:28] <-- Netmage left irc: Quit: Textual IRC Client: www.textualapp.com
[16:32] <snover> good day
[16:34] <wjp> morning
[16:36] <snover> thanks again for the reviews :)
[16:39] <wjp> sure; sorry it's taking so long
[16:45] Nick change: Deledrius__ -> Deledrius
[16:56] <-- Cheeseness left irc: Ping timeout: 268 seconds
[16:56] --> peterkohaut joined #scummvm.
[17:02] --> Cheeseness joined #scummvm.
[17:02] --> SylvainTV joined #scummvm.
[17:02] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[17:03] --> phyber_ joined #scummvm.
[17:03] <-- phyber left irc: Read error: Connection reset by peer
[17:03] --> frankyboy_ joined #scummvm.
[17:03] Nick change: phyber_ -> phyber
[17:16] <snover> no worries. it doesnt block anything on my side :)
[18:02] --> Littleboy joined #scummvm.
[18:02] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[18:28] <rsn8887> I have been looking at aspect correction some more and I think it could definitely be improved. Currently AR, if enabled, kicks i. For ANY game that runs in a screen mode with 200 lines or 400 lines. However I am pretty sure that some games such as Dreamweb should have it disabled even though they run in 200 lines, and other games that don't use 200 lines probably should have it enabled if they or
[18:28] <rsn8887> iginally ran on a platform with rectangular pixels. Also the AR currently only stretches 200-240 but it should be able to stretch any resolution to any ratio depending on the original games pixel height/width ratio
[18:30] <rsn8887> But then the menu is currently designed to display well in 320x240 or twice those resolutions. This is opening a can of worms of legacy stuff. So I will stop working on it and focus on other things.
[18:31] <rsn8887> But it could be a summer of code to fix that and make the menu more robust or work at any resolution.
[18:35] <rsn8887> In the vita port I implemented AR as a simple hardware stretch to 4:3 it works well, is fast, distorts the menu only slightly, but a better name for it would be "force 4:3 aspect" I think that name is much more clear in general because it describes what is being done. Compared to the old name which is nebulous.
[18:37] <-- Strangerke left irc: Ping timeout: 255 seconds
[18:42] <rsn8887> For example rear touch support on the Vita it would be awesome to use touch without the hand and fingers getting in the way of graphics.
[19:00] <Henke37> really, the whole system is coupled the wrong way around
[19:00] <Henke37> the game engine dictates when the graphics get updated
[19:01] <Henke37> which makes the emulator gui depedent on when the game engine feels like updating
[19:01] <Henke37> except, it doesn't even work like that at all
[19:01] <Henke37> when emulator ui is shown, the entire game engine is paused. by means of spinning up an inner main loop
[19:04] Deledrius (Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e) left #scummvm ("Net.LinkToMyPersonalAge").
[19:07] --> jamm joined #scummvm.
[19:18] --> Deledrius joined #scummvm.
[19:27] --> LyTchet joined #scummvm.
[19:29] --> dreammaster joined #scummvm.
[19:29] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[19:43] --> GitHub14 joined #scummvm.
[19:43] <GitHub14> [scummvm] m-kiewitz pushed 1 new commit to master: https://git.io/vyT1U
[19:43] <GitHub14> scummvm/master 77d232f Martin Kiewitz: AGI: always stop sound/music, when calling restore/save since 2.272...
[19:43] GitHub14 (GitHub14@192.30.252.42) left #scummvm.
[19:54] --> macdude22 joined #scummvm.
[19:58] <-- heroux left irc: Ping timeout: 255 seconds
[19:59] --> heroux joined #scummvm.
[20:03] --> GitHub181 joined #scummvm.
[20:03] <GitHub181> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vyTMl
[20:03] <GitHub181> scummvm/master 16d21cd Paul Gilbert: TITANIC: Fix CStarPoints2 initialization
[20:03] GitHub181 (GitHub181@192.30.252.42) left #scummvm.
[20:16] <-- LyTchet left irc:
[20:19] <-- rsn8887 left irc: Ping timeout: 240 seconds
[20:19] <snover> m_kiewitz: do you have an idb easily at hand for jones CD and can tell me whether or not kRandom includes code for getting/setting the RNG for 0-arg and 1-arg variants?
[20:19] <snover> RNG seed*
[20:19] --> rsn8887 joined #scummvm.
[20:20] <-- jamm left irc: Ping timeout: 240 seconds
[20:21] <snover> i checked lsl1vga and it isnt there, so think it doesnt show up until sci1late, but would like to be a little more certain about it than i am
[20:23] <snover> (lighthouse does the 0-arg call, so i figured i might as well figure out exactly where it started to exist and use the correct version guard)
[20:28] <-- ny00123 left irc: Quit: Leaving
[20:28] --> ny00123 joined #scummvm.
[20:29] <m_kiewitz> snover: please do not change anything on that level for anything sci16
[20:30] <m_kiewitz> im petty sure i already went through on very long investigation on kRandom some years ago because of some issue
[20:30] <m_kiewitz> and you simply can NOT simply check 1 or 2 interpreters in that case
[20:30] <m_kiewitz> you need to exactly identify when a change happened, then verify that it didn't also happened on a one off before that (which also happens)
[20:30] <m_kiewitz> otherwise you will break stuff
[20:32] <m_kiewitz> which is also a pain in the ... to figure out, because there are so many versions
[20:36] <wjp> (kRandom in jonescd and lsl1sci are identical)
[20:36] <snover> ok, i wont change it for sci16, but i will say 0-arg just goes to an error() so couldnt be broken, and 1-arg does the wrong thing in sci1late/1.1 if its ever actually used there
[20:37] <snover> wjp: thanks
[20:39] <snover> not that i know that anyone would be able to ever notice this, especially in sci32 since the rng seed became a 32-bit number but the VM can only get 16 bits of it
[20:44] --> GitHub78 joined #scummvm.
[20:44] <GitHub78> [scummvm] sev- pushed 1 new commit to master: https://git.io/vyTyM
[20:44] <GitHub78> scummvm/master 27a0f43 Eugene Sandulenko: DIRECTOR: Move utility functions to util.cpp
[20:44] GitHub78 (GitHub78@192.30.252.42) left #scummvm.
[20:45] <m_kiewitz> snover: did they keep that exact "get random number in range" code in sci32?
[20:45] <snover> i assume so, i didnt check that part, or if i did it was a long time ago and i forgot :)
[20:46] <m_kiewitz> well it would be interesting
[20:47] <m_kiewitz> they calculated the range in a specific way and exactly that is needed for some sci16 games
[20:47] <m_kiewitz> but it was also a bit weird, so maybe they changed it and then it would have to get adjusted accordingly
[20:47] <m_kiewitz> back then it was a pita to get for example the door codes working in larry 5 because of that
[20:48] --> lavosspawn joined #scummvm.
[20:48] <m_kiewitz> although what's wrong about the 1-argc thing?
[20:50] <snover> its supposed to set the seed from argv[0] but it does nothing
[20:51] <m_kiewitz> yes, we also don't use the exact same method of creating random numbers, that was done intentionally
[20:51] <m_kiewitz> we just get the random numbers from ScummVMs RNG if I remember correctly
[20:52] <m_kiewitz> so even if we used the seed, there wouldn't really be a point to it, because the games wouldn't get the same random numbers anyway
[20:53] <m_kiewitz> it seems with argc not being 1 or 2, it actually would have returned the seed
[20:53] <m_kiewitz> what does sci32 do?
[20:53] <-- Tkachov left irc: Read error: Connection reset by peer
[20:54] <m_kiewitz> does lighthouse read the seed and set it later?
[20:55] <snover> good question
[20:55] <snover> i got a little ahead of myself
[20:56] <m_kiewitz> there are also 2 kRandom workarounds for Torin right now, what does Torin do? sadly the one adding those didn't mention what the scripts do :(
[20:56] <snover> also a good question that i was wondering about.
[20:56] <snover> i mean, i can say from the disassembly that sci32 returns the low 16 bits of the seed
[20:57] <-- Deledrius left irc: Read error: Network is unreachable
[20:57] <snover> but i dont know yet exactly why lighthouse is using it. and i guess i need to work on save games a little more, since the lighthouse ones are broken once you go past the first area.
[20:57] --> Deledrius joined #scummvm.
[20:58] <m_kiewitz> and the scripts are calling it that way? and they save the seed?
[20:58] <m_kiewitz> in theory they could use that feature to get the same numbers back several times
[20:59] <snover> yeah, that was the conclusion i jumped to :)
[20:59] <snover> but i need several minutes to figure out what room i was in when it did that, so i can verify that it sets it
[20:59] <m_kiewitz> well, for sci16 i'm not really sure, if it would be a wise choice to allow no parameters via signatures
[21:00] <m_kiewitz> because it's quite obviously never used and if we wanted to be that accurate, we would have to allow any type of parameter because sierra did the same
[21:00] <m_kiewitz> you could have called it with kRandom(object, integer, integer, object) and it would have returned the seed too
[21:00] <m_kiewitz> sci32 needs to investigated of course
[21:01] <m_kiewitz> did that code stay like that for all of sci32?
[21:03] <snover> sec, diffing
[21:05] <m_kiewitz> wow, Torin's Passage looks basically perfect now
[21:06] <m_kiewitz> "Lycentia knocks Torin out", who's Lycentia?
[21:06] <snover> the antagonist
[21:07] <m_kiewitz> oh i see, and when does that guy/girl knock Torin out?
[21:07] <snover> unfortunately, i have no idea. i didnt add those workarounds
[21:07] <-- Deledrius left irc: Read error: Network is unreachable
[21:07] <m_kiewitz> either it was really kRandom(), or had some garbage data on top
[21:07] <snover> try just navigating to that room from the debugger i guess
[21:07] --> Deledrius joined #scummvm.
[21:08] <m_kiewitz> no idea how to get her to punch Torin
[21:16] <m_kiewitz> hmm in case lighthouse would really need that functionality, we would probably have to find a way with that seed
[21:17] <m_kiewitz> right now Common::RandomSource uses a uin32 as seed, so no way for a script to save it
[21:22] <wjp> well
[21:23] <wjp> there's a lot of potential reg_t tricks if it's important enough
[21:24] <wjp> (and, oh, workarounds for not fully implemented functionality? :-( )
[21:25] <-- ajax16384 left irc: Read error: Connection reset by peer
[21:25] --> Tkachov joined #scummvm.
[21:26] <snover> sorry, i had to go lay down for a minute.
[21:28] <snover> functionally, it looks like everything is the same for all of sci32, except that argc=3 gets dropped in sci3
[21:28] <snover> and is effectively a no-op if it is ever called
[21:30] <snover> the RNG seed in SSCI is 32-bits, and it also takes only the low 16 bits for the VM, so it looks like that shouldnt cause an incompatibility
[21:33] <snover> though& i am wedded to much to my fully filled out SQ6 IDB :) for lighthouse the 32-bit accumulator means the entire seed would fit into it
[21:34] <m_kiewitz> snover: we got 2 workarounds for torin, one is for cycleDone and I only see this code for cycleDone:
[21:34] <m_kiewitz> code_04db: push2
[21:34] <m_kiewitz> pTos waitMin
[21:34] <m_kiewitz> pTos waitMax
[21:34] <m_kiewitz> callk Random, $4
[21:34] <m_kiewitz> and that should work I guess?
[21:34] <-- heroux left irc: Ping timeout: 260 seconds
[21:34] --> Deledrius_ joined #scummvm.
[21:34] <-- frankyboy_ left irc: Remote host closed the connection
[21:35] <snover> i really need to look at the lighthouse game script and see where it is storing this value, since i still think it would get truncated eventually
[21:35] <snover> m_kiewitz: yeah
[21:35] <m_kiewitz> wjp: we still have no idea for what situation those workarounds were added
[21:35] <snover> those workarounds dont make a lot of sense to me either
[21:35] <m_kiewitz> wjp: at least the cycleDone makes no sense to me, but maybe there is another version of Torin, idk
[21:36] <snover> i mean, if lighthouse calls kRandom argc=1, even in SSCI3, that can still only be a 16-bit value
[21:36] <snover> im gonna stop talking in circles and find the correct game script&:)
[21:36] <m_kiewitz> maybe thoses cases are script bugs then?
[21:36] <m_kiewitz> if they only got 16 bits of the seed, they couldn't reproduce the values anyway
[21:37] <-- Deledrius left irc: Ping timeout: 240 seconds
[21:37] <wjp> snover: do you see any calls with argc == 1 in Lighthouse?
[21:37] <snover> wjp: yeah, that is how this whole thing started.
[21:37] <snover> er
[21:37] <m_kiewitz> and what's that argument?
[21:37] <snover> no
[21:37] <snover> sorry
[21:38] <snover> aaaaa
[21:38] <snover> !
[21:38] --> omer_mor joined #scummvm.
[21:38] <m_kiewitz> ?!?!
[21:38] <snover> i saw an argc=0 and it crashed on it
[21:38] <wjp> I only see 0 and 2
[21:38] <m_kiewitz> where are the argc=0?
[21:38] <m_kiewitz> script?
[21:38] <wjp> rm447::init
[21:38] <m_kiewitz> is it doing anything with _acc?
[21:39] <m_kiewitz> super LightRoom, $4
[21:39] <m_kiewitz> push0
[21:39] <m_kiewitz> callk Random, $0
[21:39] <m_kiewitz> o_O
[21:39] <m_kiewitz> looks like a script bug
[21:40] <m_kiewitz> callk Random, $0
[21:40] <m_kiewitz> push1
[21:40] <m_kiewitz> pushi $171 ; 369, nextRoom
[21:40] <m_kiewitz> callb export000_5, $2
[21:40] <-- omer_mor_ left irc: Ping timeout: 240 seconds
[21:40] <m_kiewitz> but well, we can just accept no arguments and return NULL_REG
[21:41] <m_kiewitz> snover: sci32 doesn't use kRandom() to init the RNG?
[21:42] <snover> im not sure, i never looked for that. if it ever did that it wouldve just been silently ignored by the existing kRandom code
[21:42] <m_kiewitz> maybe a SCI dev thought it would
[21:42] <m_kiewitz> really weird
[21:44] <snover> i guess i caused a lot of confusion for nothing. sorry :(
[21:44] <m_kiewitz> nah we should really change signatures and open it up
[21:44] <m_kiewitz> and you aren't the SCI developer who called it like that anyway :P
[21:45] <m_kiewitz> you should really verify the range calculation in sci32 though and if it's really 100% the same
[21:45] <m_kiewitz> because if they changed it, that could cause some tiny minor issue somewhere
[21:45] --> heroux joined #scummvm.
[21:46] <-- ny00123 left irc: Quit: Leaving
[21:47] <snover> mov eax, [esp+4+high]; sub eax, [esp+4+low]; inc eax;
[21:47] <snover> so, the same
[21:49] <snover> there is not that reverse order thing from longbow/kq5cd, though i dont know if it ever gets triggered
[21:50] <m_kiewitz> that depends on how the RNG returned the numbers depending on the range
[21:51] <m_kiewitz> hmm if we only had a debugger for the original sci32 for testing those edge cases out
[21:59] <wjp> do we have a compiler for sci32 scripts?
[21:59] <wjp> or assembler
[22:00] <m_kiewitz> i doubt it. we could change scripts manually of course.
[22:00] <m_kiewitz> snover: shall i change up kRandom accordingly?
[22:01] <snover> m_kiewitz: sorry, I am apparently confused today :) you are speaking of changing the kernel signature?
[22:02] <m_kiewitz> yes and a tiny bit of code
[22:02] <m_kiewitz> i will pobably add a warning for kRandom() calls (without parameters)
[22:02] <m_kiewitz> so that we see when this happens
[22:03] <snover> Sounds OK to me. Seems lighthouse just needs to be script patched to remove the bogus call
[22:03] <snover> And I have not seen it anywhere else yet
[22:04] <m_kiewitz> i will also remove the workarounds for torin
[22:08] <-- Begas_VBox left irc: Quit: Vision[0.9.8]: i've been blurred!
[22:09] --> Begas_VBox joined #scummvm.
[22:10] <snover> OK.
[22:10] <-- heroux left irc: Ping timeout: 255 seconds
[22:24] <m_kiewitz> snover: shall I actually return the seed for those cases?
[22:24] <m_kiewitz> or just return NULL_REG?
[22:24] <m_kiewitz> it's difficult, I guess we should expect all of those calls to be script bugs first of all
[22:25] <snover> Might as well do what ssci did since we can
[22:26] <m_kiewitz> i have no clue why kRandom is inside kmath.cpp, btw. I would expect it inside kmisc.cpp
[22:26] --> heroux joined #scummvm.
[22:26] <waltervn> wjp: I add SCI2 support to scis a few years ago, but I doubt anyone has tried it besides me...
[22:26] <waltervn> *added
[22:27] <waltervn> make that 5 years ago, yikes. Time really does fly
[22:43] <waltervn> looks like my ISP is having trouble again... sigh
[22:49] --> cody56 joined #scummvm.
[22:50] --> Strangerke joined #scummvm.
[22:52] <-- lavosspawn left irc: Ping timeout: 255 seconds
[22:53] <-- ST left irc: Quit: Leaving.
[22:57] <-- waltervn left irc: Quit: Leaving
[22:58] --> ST joined #scummvm.
[22:58] #scummvm: mode change '+o ST' by ChanServ!ChanServ@services.
[23:05] <-- Begasus left irc: Quit: Ex-Chat
[23:05] <-- Begas_VBox left irc: Quit: Vision[0.9.8]: i've been blurred!
[23:19] <snover> as far as which file kRandom is in, in SSCI it probably was also in a math file since it is surrounded by other math operations. it also doesnt seem so strange to me, but thats because i have like 18 years of experience in a language where it lives at Math.random :)
[23:21] --> GitHub16 joined #scummvm.
[23:21] <GitHub16> [scummvm] sev- pushed 2 new commits to master: https://git.io/vyTbN
[23:21] <GitHub16> scummvm/master 45b4135 Eugene Sandulenko: DIRECTOR: More debug output when loading
[23:21] <GitHub16> scummvm/master 29b32d5 Eugene Sandulenko: DIRECTOR: Clarified and corrected movie scripts in D2/D3
[23:21] GitHub16 (GitHub16@192.30.252.41) left #scummvm.
[23:24] <-- vinayakvivek left irc: Quit: Connection closed for inactivity
[23:25] --> GitHub156 joined #scummvm.
[23:25] <GitHub156> [scummvm] m-kiewitz pushed 1 new commit to master: https://git.io/vyTNt
[23:25] <GitHub156> scummvm/master 26b6d45 Martin Kiewitz: SCI: Clean up kRandom + allow 0 parameters via signatures...
[23:25] GitHub156 (GitHub156@192.30.252.42) left #scummvm.
[23:25] <m_kiewitz> snover: ^^ hope it works
[23:26] <m_kiewitz> just went through quite a few interpreters, 0.530 and earlier didn't even check if the amount of parameters were passed and just read them in any case
[23:32] <snover> well it compiles, so i think we can ship it ;)
[23:33] <snover> i really gotta fix these save games now though, before anything else&
[23:36] <m_kiewitz> there seems to be some corruption going on somewhere
[23:40] <snover> i think it is robot memory that needs to be cleaned up & serialised
[23:42] <snover> so, thats what i am working on at the moment
[23:48] <-- Farmboy0 left irc: Remote host closed the connection
[00:00] --- Sun Feb 26 2017